Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: graphsim: An R package for simulating gene expression data from graph structures of biological pathways #2161

Closed
38 tasks done
whedon opened this issue Mar 12, 2020 · 125 comments
Assignees
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review

Comments

@whedon
Copy link

whedon commented Mar 12, 2020

Submitting author: @TomKellyGenetics (S. Thomas Kelly)
Repository: https://github.com/TomKellyGenetics/graphsim
Version: v1.0.0-joss
Editor: @majensen
Reviewer: @rcannood, @corybrunson
Archive: 10.5281/zenodo.3931288

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6"><img src="https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6/status.svg)](https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rcannood & @corybrunson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.

Please try and complete your review in the next two weeks

Review checklist for @rcannood

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@TomKellyGenetics) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @corybrunson

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@TomKellyGenetics) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?
@whedon
Copy link
Author

whedon commented Mar 12, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @rcannood, @corybrunson it looks like you're currently assigned to review this paper 🎉.

⭐ Important ⭐

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 12, 2020

@whedon
Copy link
Author

whedon commented Mar 12, 2020

Reference check summary:

OK DOIs

- 10.1186/gb-2014-15-2-r29 is OK
- 10.1186/1752-0509-3-41 is OK
- 10.1093/bioinformatics/btm639 is OK
- 10.1016/j.copbio.2007.11.005 is OK
- 10.1515/jib-2017-0027 is OK
- 10.1093/imanum/22.3.329 is OK
- 10.1186/s13062-015-0086-1 is OK
- 10.1101/gad.11.13.1748 is OK
- 10.1093/bioinformatics/btp174 is OK
- 10.1093/bioinformatics/btu736 is OK
- 10.1093/hmg/ddu309 is OK
- 10.1016/0022-2836(75)90213-2 is OK
- 10.1016/j.socnet.2004.11.008 is OK
- 10.1007/BF01386390 is OK
- 10.1177/1558689812454457 is OK
- 10.1111/j.1651-2227.2006.00178.x is OK
- 10.1016/j.patrec.2005.10.010 is OK
- 10.1124/jpet.103.064824 is OK
- 10.1016/j.cell.2009.02.024 is OK
- 10.1103/PhysRevLett.87.198701 is OK
- 10.1039/C3MB25589A is OK
- 10.1186/gb-2010-11-3-r25 is OK
- 10.1186/1471-2407-14-552 is OK
- 10.1016/j.fob.2012.04.003 is OK
- 10.1200/JCO.2008.18.1370 is OK
- 10.1016/S0169-7552(98)00110-X is OK
- 10.1093/nar/gkt1102 is OK
- 10.1093/bioinformatics/btl633 is OK
- 10.1093/annonc/mdg486 is OK
- 10.1093/hmg/ddp046 is OK
- 10.1016/S0968-0004(98)01343-7 is OK
- 10.1016/S1357-4310(99)01461-6 is OK
- 10.1016/S0959-8049(00)00158-1 is OK
- 10.1053/gast.2001.29611 is OK
- 10.1001/jama.297.21.2360 is OK
- 10.1371/journal.pgen.1003254 is OK
- 10.1186/1479-5876-7-43 is OK
- 10.1038/nrd3374 is OK
- 10.1158/1078-0432.ccr-13-3116 is OK
- 10.1016/j.ddtec.2013.12.002 is OK
- 10.1038/nrg3899 is OK
- 10.1016/j.cell.2015.11.015 is OK
- 10.1186/gb-2004-5-10-r80 is OK

MISSING DOIs

- https://doi.org/10.1038/nrg2934 may be missing for title: RNA sequencing: advances, challenges and opportunities
- https://doi.org/10.1101/227033 may be missing for title: Gene expression distribution deconvolution in single-cell RNA sequencing
- https://doi.org/10.3389/fgene.2019.00535 may be missing for title: Inferring Interaction Networks From Multi-Omics Data
- https://doi.org/10.1186/1471-2105-8-s6-s5 may be missing for title: Inferring cellular networks–a review
- https://doi.org/10.1038/nprot.2017.149 may be missing for title: Exponential scaling of single-cell RNA-seq in the past decade
- https://doi.org/10.1038/nrg.2016.87 may be missing for title: Network biology concepts in complex disease comorbidities
- https://doi.org/10.1186/s12859-015-0778-7 may be missing for title: Comparing the normalization methods for the differential analysis of Illumina high-throughput RNA-Seq data
- https://doi.org/10.1109/msp.2007.273053 may be missing for title: Finding module-based gene networks with state-space models - Mining high-dimensional and short time-course gene expression data
- https://doi.org/10.3892/ijo.2012.1744 may be missing for title: Molecular features of triple negative breast cancer cells by genome-wide gene expression profiling analysis
- https://doi.org/10.1186/s12967-017-1197-5 may be missing for title: Transcriptomic profiling and quantitative high-throughput (qHTS) drug screening of CDH1 deficient hereditary diffuse gastric cancer (HDGC) cells identify treatment leads for familial gastric cancer
- https://doi.org/10.1109/csb.2003.1227309 may be missing for title: Combining microarrays and biological knowledge for estimating gene networks via bayesian networks
- https://doi.org/10.1126/science.1087361 may be missing for title: A Bayesian networks approach for predicting protein-protein interactions from genomic data
- https://doi.org/10.1371/journal.pcbi.1002110 may be missing for title: Bayesian inference for genomic data integration reduces misclassification rate in predicting protein-protein interactions
- https://doi.org/10.1186/bcr2887 may be missing for title: Three interrelated themes in current breast cancer research: gene addiction, phenotypic plasticity, and cancer stem cells
- https://doi.org/10.1007/s10555-016-9626-0 may be missing for title: Thrombin-unique coagulation system protein with multifaceted impacts on cancer and metastasis
- https://doi.org/10.1093/bioinformatics/btp692 may be missing for title: RNA-Seq gene expression estimation with read mapping uncertainty
- https://doi.org/10.1093/nar/gkl811 may be missing for title: CancerGenes: a gene selection resource for cancer genome projects
- https://doi.org/10.1111/1567-1364.12094 may be missing for title: The expanding role of yeast in cancer research and diagnosis: insights into the function of the oncosuppressors p53 and BRCA1/2
- https://doi.org/10.3390/ijms10062763 may be missing for title: Yeast two-hybrid, a powerful tool for systems biology
- https://doi.org/10.1002/path.4842 may be missing for title: Cancer predisposition syndromes: lessons for truly precision medicine
- https://doi.org/10.3322/caac.21329 may be missing for title: Translating cancer genomes and transcriptomes for precision oncology
- https://doi.org/10.1038/nrg.2016.49 may be missing for title: Coming of age: ten years of next-generation sequencing technologies
- https://doi.org/10.1038/79120 may be missing for title: Methylation of the CDH1 promoter as the second genetic hit in hereditary diffuse gastric cancer
- https://doi.org/10.1038/aps.2012.30 may be missing for title: E-cadherin promotes proliferation of human ovarian cancer cells in vitro via activating MEK/ERK pathway
- https://doi.org/10.1038/onc.2012.563 may be missing for title: Soluble E-cadherin: a critical oncogene modulating receptor tyrosine kinases, MAPK and PI3K/Akt/mTOR signaling
- https://doi.org/10.1038/onc.2008.470 may be missing for title: E-cadherin directly contributes to PI3K/AKT activation by engaging the PI3K-p85 regulatory subunit to adherens junctions of ovarian carcinoma cells
- https://doi.org/10.1038/onc.2008.343 may be missing for title: Cadherins and cancer: how does cadherin dysfunction promote tumor progression?
- https://doi.org/10.1371/journal.pone.0046665 may be missing for title: Down-regulation of CDH1 is associated with expression of SNAI1 in colorectal adenomas
- https://doi.org/10.1038/sj.bjc.6604560 may be missing for title: Reduced expression of a gene proliferation signature is associated with enhanced malignancy in colon cancer
- https://doi.org/10.1186/gb-2013-14-4-r34 may be missing for title: Interactions between immunity, proliferation and molecular subtype in breast cancer prognosis
- https://doi.org/10.1038/ng.2984 may be missing for title: Recurrent gain-of-function mutations of RHOA in diffuse-type gastric carcinoma
- https://doi.org/10.1038/ng.2983 may be missing for title: Whole-genome sequencing and comprehensive molecular profiling identify new driver mutations in gastric cancer
- https://doi.org/10.1038/ng.3073 may be missing for title: An integrated genomics approach identifies drivers of proliferation in luminal-subtype human breast cancer
- https://doi.org/10.1186/bcr2899 may be missing for title: Analysis of tumor environmental response and oncogenic pathway activation identifies distinct basal and luminal features in HER2-related breast tumor subtypes
- https://doi.org/10.1142/9789814434478_0005 may be missing for title: An algorithm for drawing general undirected graphs
- https://doi.org/10.1093/nar/gkv1108 may be missing for title: SynLethDB: synthetic lethality database toward discovery of selective and sensitive anticancer drug targets
- https://doi.org/10.1038/nature03001 may be missing for title: Finishing the euchromatic sequence of the human genome
- https://doi.org/10.1038/ejhg.2012.247 may be missing for title: Clinical utility gene card for: Hereditary diffuse gastric cancer (HDGC)
- https://doi.org/10.1038/nature14129 may be missing for title: Comprehensive genomic characterization of head and neck squamous cell carcinomas
- https://doi.org/10.1038/nature12222 may be missing for title: Comprehensive molecular characterization of clear cell renal cell carcinoma
- https://doi.org/10.1038/nature21386 may be missing for title: Integrated genomic and molecular characterization of cervical cancer
- https://doi.org/10.1038/nature11252 may be missing for title: Comprehensive molecular characterization of human colon and rectal cancer
- https://doi.org/10.1038/ng.2764 may be missing for title: The Cancer Genome Atlas Pan-Cancer analysis project
- https://doi.org/10.1126/science.1084564 may be missing for title: The Human Genome Project: lessons from large-scale biology
- https://doi.org/10.1038/nbt1485 may be missing for title: The development and impact of 454 sequencing
- https://doi.org/10.1093/bioinformatics/btv733 may be missing for title: PaxtoolsR: pathway analysis in R using Pathway Commons
- https://doi.org/10.1371/journal.pcbi.1003194 may be missing for title: Using biological pathway data with Paxtools
- https://doi.org/10.1093/nar/gkq1039 may be missing for title: Pathway Commons, a web resource for biological pathway data
- https://doi.org/10.1093/bioinformatics/bti623 may be missing for title: ROCR: visualizing classifier performance in R
- https://doi.org/10.1093/clinchem/39.4.561 may be missing for title: Receiver-operating characteristic (ROC) plots: a fundamental evaluation tool in clinical medicine.
- https://doi.org/10.1186/gb-2009-10-3-r25 may be missing for title: Ultrafast and memory-efficient alignment of short DNA sequences to the human genome
- https://doi.org/10.1093/nar/gkq622 may be missing for title: MapSplice: accurate mapping of RNA-seq reads for splice junction discovery
- https://doi.org/10.1038/ncomms11908 may be missing for title: Erratum: The somatic mutation profiles of 2,433 breast cancers refine their genomic and transcriptomic landscapes
- https://doi.org/10.1038/nature10983 may be missing for title: The genomic and transcriptomic architecture of 2,000 breast tumours reveals novel subgroups
- https://doi.org/10.1038/nbt.1637 may be missing for title: Comparative assessment of methods for aligning multiple genome sequences
- https://doi.org/10.1093/bib/bbl026 may be missing for title: Open source tools and toolkits for bioinformatics: significance, and where are we?
- https://doi.org/10.1038/nrg3394 may be missing for title: Reuse of public genome-wide gene expression data
- https://doi.org/10.1093/nar/gks1174 may be missing for title: ArrayExpress update–trends in database growth and links to data analysis tools
- https://doi.org/10.1016/j.ctrv.2011.11.005 may be missing for title: Molecular biology in breast cancer: intrinsic subtypes and signaling pathways
- https://doi.org/10.1200/jco.20.5.1260 may be missing for title: Outcome of preventive surgery and screening for breast and ovarian cancer in BRCA mutation carriers
- https://doi.org/10.1186/gb-2007-8-5-r76 may be missing for title: Identification of conserved gene expression features between murine mammary carcinoma models and human breast tumors
- https://doi.org/10.1634/theoncologist.2010-s5-39 may be missing for title: Molecular stratification of triple-negative breast cancers
- https://doi.org/10.1261/rna.1947110 may be missing for title: Systematic comparison of microarray profiling, real-time PCR, and next-generation sequencing technologies for measuring differential microRNA expression
- https://doi.org/10.1373/clinchem.2015.249623 may be missing for title: Systematic Evaluation of Sanger Validation of Next-Generation Sequencing Variants
- https://doi.org/10.1371/journal.pone.0103917 may be missing for title: A method for quantitative analysis of standard and high-throughput qPCR expression data based on input sample quantity
- https://doi.org/10.1126/science.1105136 may be missing for title: The ENCODE (ENCyclopedia Of DNA Elements) Project
- https://doi.org/10.14343/jcscr.2016.4e1003 may be missing for title: Cancer incidence and mortality worldwide: sources, methods and major patterns in GLOBOCAN 2012
- https://doi.org/10.1200/jco.2006.09.1066 may be missing for title: Meta-analysis of BRCA1 and BRCA2 penetrance
- https://doi.org/10.1093/carcin/21.5.857 may be missing for title: Disorders in cell circuitry during multistage carcinogenesis: the role of homeostasis
- https://doi.org/10.1093/nar/gku1179 may be missing for title: Gene Ontology Consortium: going forward
- https://doi.org/10.1186/bcr326 may be missing for title: Update on HER-2 as a target for cancer therapy: herceptin in the clinical setting
- https://doi.org/10.1016/j.yane.2012.02.046 may be missing for title: Hallmarks of cancer: the next generation
- https://doi.org/10.1038/452788b may be missing for title: James Watson’s genome sequenced at high speed
- https://doi.org/10.1038/44413 may be missing for title: Wellcome funds cancer database
- https://doi.org/10.1073/pnas.70.12.3581 may be missing for title: The Nucleotide Sequence of the lac Operator
- https://doi.org/10.1158/1535-7163.mct-14-0845 may be missing for title: Functional Genetic Screen Identifies Increased Sensitivity to WEE1 Inhibition in Cells with Defects in Fanconi Anemia and HR Pathways
- https://doi.org/10.1200/jco.2008.16.0812 may be missing for title: A synthetic lethal therapeutic approach: poly(ADP) ribose polymerase inhibitors for the treatment of cancers deficient in DNA double-strand break repair
- https://doi.org/10.1016/j.cell.2011.03.020 may be missing for title: Genetic interactions in cancer progression and treatment
- https://doi.org/10.1371/journal.pgen.1004120 may be missing for title: Quantitative genome-wide genetic interaction screens reveal global epistatic relationships of protein complexes in Escherichia coli
- https://doi.org/10.1097/00006842-200405000-00021 may be missing for title: What you see may not be what you get: a brief, nontechnical introduction to overfitting in regression-type models
- https://doi.org/10.1515/9781400841356.321 may be missing for title: On the properties of small-world network models
- https://doi.org/10.1016/s0076-6879(10)70007-0 may be missing for title: Synthetic genetic array (SGA) analysis in Saccharomyces cerevisiae and Schizosaccharomyces pombe
- https://doi.org/10.1186/1471-2164-15-158 may be missing for title: High throughput synthetic lethality screen reveals a tumorigenic role of adenylate cyclase in fumarate hydratase-deficient cancer cells
- https://doi.org/10.1038/nrg2085 may be missing for title: Exploring genetic interactions and networks with yeast
- https://doi.org/10.3389/fgene.2013.00290 may be missing for title: Genetic interaction networks: better understand to better predict
- https://doi.org/10.1038/ng0806-862 may be missing for title: From worm genetic networks to complex human diseases
- https://doi.org/10.1186/1471-2105-10-17 may be missing for title: Predicting genetic interactions with random walks on biological networks
- https://doi.org/10.1016/j.copbio.2010.11.001 may be missing for title: Charting the genetic interaction map of a cell
- https://doi.org/10.1038/ng1640 may be missing for title: The synthetic genetic interaction spectrum of essential genes
- https://doi.org/10.1158/0008-5472.can-12-3956 may be missing for title: A comparative genomic approach for identifying synthetic lethal interactions in human cancer
- https://doi.org/10.4161/cib.7501 may be missing for title: Exploring the conservation of synthetic lethal genetic interaction networks
- https://doi.org/10.1073/pnas.0806261105 may be missing for title: Significant conservation of synthetic lethal genetic interaction networks between distantly related eukaryotes
- https://doi.org/10.1017/s0080456800012163 may be missing for title: XV.—The Correlation between Relatives on the Supposition of Mendelian Inheritance
- https://doi.org/10.1038/sj.onc.1208044 may be missing for title: Towards full employment: using RNAi to find roles for the redundant
- https://doi.org/10.1002/widm.1055 may be missing for title: Mining high-throughput screens for cancer drug targets-lessons from yeast chemical-genomic profiling and synthetic lethality
- https://doi.org/10.1371/journal.pone.0060847 may be missing for title: Systematic Analysis of Experimental Phenotype Data Reveals Gene Functions
- https://doi.org/10.1103/physreve.65.026107 may be missing for title: Growing scale-free networks with tunable clustering
- https://doi.org/10.1038/nchembio.118 may be missing for title: Network pharmacology: the next paradigm in drug discovery
- https://doi.org/10.1016/j.cell.2014.07.027 may be missing for title: Predicting Cancer-Specific Vulnerability via Data-Driven Detection of Synthetic Lethality
- https://doi.org/10.1038/nbt1096 may be missing for title: Systematic interpretation of genetic interactions using protein networks
- https://doi.org/10.1038/nmeth.2436 may be missing for title: Mapping genetic interactions in human cancer cells with RNAi and multiparametric phenotyping
- https://doi.org/10.1371/journal.pone.0010624 may be missing for title: Searching for Signaling Balance through the Identification of Genetic Interactors of the Rab Guanine-Nucleotide Dissociation Inhibitor gdi-1
- https://doi.org/10.1101/gr.102749.109 may be missing for title: Predicting genetic modifier loci using functional gene networks
- https://doi.org/10.1007/978-1-59745-243-4_20 may be missing for title: Effects of functional bias on supervised learning of a gene network model
- https://doi.org/10.1016/j.cell.2012.03.031 may be missing for title: Sequential application of anticancer drugs enhances cell death by rewiring apoptotic signaling networks
- https://doi.org/10.1186/1752-0509-5-73 may be missing for title: Understanding and predicting synthetic lethal genetic interactions in Saccharomyces cerevisiae using domain genetic interactions
- https://doi.org/10.1109/bibm.2013.6732609 may be missing for title: Syn-Lethality: An Integrative Knowledge Base of Synthetic Lethality towards Discovery of Selective Anticancer Therapies
- https://doi.org/10.1038/ncomms3124 may be missing for title: Genome evolution predicts genetic interactions in protein complexes and reveals cancer drug targets
- https://doi.org/10.1037/e400002009-005 may be missing for title: The Small World Problem
- https://doi.org/10.1038/ng1258 may be missing for title: DNA helicase gene interaction network defined using synthetic lethality analyzed by microarray
- https://doi.org/10.1186/1471-2105-9-426 may be missing for title: Mining protein networks for synthetic genetic interactions
- https://doi.org/10.1371/journal.pcbi.1000928 may be missing for title: An integrative multi-network and multi-classifier approach to predict genetic interactions
- https://doi.org/10.1101/gr.077693.108 may be missing for title: Finding friends and enemies in an enemies-only network: A graph diffusion kernel for predicting novel genetic interactions and co-complex membership from yeast genetic interactions
- https://doi.org/10.1126/science.1162609 may be missing for title: Conservation and rewiring of functional modules revealed by an epistasis map in fission yeast
- https://doi.org/10.1038/nmeth1098 may be missing for title: High-throughput genetic interaction mapping in the fission yeast Schizosaccharomyces pombe
- https://doi.org/10.1016/j.ymeth.2006.07.034 may be missing for title: Quantitative genetic analysis in Saccharomyces cerevisiae using epistatic miniarray profiles (E-MAPs) and its application to chromatin functions
- https://doi.org/10.1016/j.neo.2014.04.007 may be missing for title: CSNK1E/CTNNB1 are synthetic lethal to TP53 in colorectal cancer and are markers for prognosis
- https://doi.org/10.1038/ng.114 may be missing for title: Evolutionary plasticity of genetic interaction networks
- https://doi.org/10.1515/9781400841356.130 may be missing for title: An Experimental Study of the Small World Problem
- https://doi.org/10.1089/104303404322959515 may be missing for title: Novel integrase-defective lentiviral episomal vectors for gene transfer
- https://doi.org/10.1093/nar/gku1075 may be missing for title: COSMIC: exploring the world’s knowledge of somatic mutations in human cancer
- https://doi.org/10.1038/msb.2013.54 may be missing for title: A negative genetic interaction map in isogenic cancer cell lines reveals cancer cell vulnerabilities
- https://doi.org/10.1186/s12864-016-2375-1 may be missing for title: Multi-omic measurement of mutually exclusive loss-of-function enriches for candidate synthetic lethal gene pairs
- https://doi.org/10.1515/9781400841356.301 may be missing for title: Collective dynamics of ’small-world’ networks
- https://doi.org/10.1073/pnas.0406614101 may be missing for title: Combining biological networks to predict genetic interactions
- https://doi.org/10.4137/cin.s14026 may be missing for title: In silico prediction of synthetic lethality by meta-analysis of genetic interactions, functions, and pathways in yeast and human cancer
- https://doi.org/10.1142/s0219720015410024 may be missing for title: Predicting essential genes and synthetic lethality via influence propagation in signaling pathways of cancer cell fates
- https://doi.org/10.1371/journal.pcbi.1003637 may be missing for title: Essential Plasticity and Redundancy of Metabolism Unveiled by Synthetic Lethality Analysis
- https://doi.org/10.3390/biom2040635 may be missing for title: Strategies for the Use of Poly(adenosine diphosphate ribose) Polymerase (PARP) Inhibitors in Cancer Therapy
- https://doi.org/10.1515/9781400841356.349 may be missing for title: Emergence of scaling in random networks
- https://doi.org/10.1038/nrg1272 may be missing for title: Network biology: understanding the cell’s functional organization
- https://doi.org/10.1038/nrg2918 may be missing for title: Network medicine: a network-based approach to human disease
- https://doi.org/10.1093/bib/bbr012 may be missing for title: Travelling the world of gene–gene interactions
- https://doi.org/10.1016/s0306-4379(97)00021-5 may be missing for title: A New and Versatile Method for Association Generation
- https://doi.org/10.1111/j.2517-6161.1995.tb02031.x may be missing for title: Controlling the False Discovery Rate: A Practical and Powerful Approach to Multiple Testing
- https://doi.org/10.1093/biostatistics/kxj037 may be missing for title: Adjusting batch effects in microarray expression data using empirical Bayes methods
- https://doi.org/10.1038/nrc1691 may be missing for title: The concept of synthetic lethality in the context of anticancer therapy
- https://doi.org/10.1186/gm99 may be missing for title: Synthetic Lethality: a framework for the development of wiser cancer therapeutics
- https://doi.org/10.1371/journal.pone.0125795 may be missing for title: Predicting human genetic interactions from cancer genome evolution
- https://doi.org/10.1002/emmm.201100150 may be missing for title: Combined genomic and phenotype screening reveals secretory factor SPINK1 as an invasion and survival factor associated with patient prognosis in breast cancer
- https://doi.org/10.1158/1535-7163.mct-14-1092 may be missing for title: Synthetic lethal screens identify vulnerabilities in GPCR signalling and cytoskeletal organization in E-cadherin-deficient cells
- https://doi.org/10.1016/j.neo.2014.04.007 may be missing for title: CSNK1E/CTNNB1 are synthetic lethal to TP53 in colorectal cancer and are markers for prognosis
- https://doi.org/10.1186/1755-8794-6-30 may be missing for title: Identification of potential synthetic lethal genes to p53 using a computational biology approach
- https://doi.org/10.1093/nar/gkv007 may be missing for title: limma powers differential expression analyses for RNA-sequencing and microarray studies
- https://doi.org/10.1083/jcb.200212033 may be missing for title: Adhesion-independent mechanism for suppression of tumor cell invasion by E-cadherin
- https://doi.org/10.1002/j.1460-2075.1995.tb00301.x may be missing for title: E-cadherin is a tumour/invasion suppressor gene mutated in human lobular breast cancers
- https://doi.org/10.1016/j.ccr.2014.08.008 may be missing for title: DAISY: Picking Synthetic Lethals from Cancer Genomes
- https://doi.org/10.1038/bjc.1997.523 may be missing for title: E-cadherin inactivation in lobular carcinoma in situ of the breast: an early event in tumorigenesis
- https://doi.org/10.1101/cshperspect.a003129 may be missing for title: Involvement of Members of the Cadherin Superfamily in Cancer
- https://doi.org/10.1002/(sici)1096-9896(199712)183:4<404::aid-path1148>3.0.co;2-9 may be missing for title: Simultaneous loss of E-cadherin and catenins in invasive lobular breast cancer and lobular carcinoma in situ
- https://doi.org/10.1038/nrc2620 may be missing for title: Transitions between epithelial and mesenchymal states: acquisition of malignant and stem cell traits

INVALID DOIs

- None

@majensen
Copy link
Member

Replicating @arfon comment here regarding trimming bibtex entries:

@TomKellyGenetics - you might want to truncate your bibtex entries to only those that are cited in the JOSS paper to prevent Whedon responses like this one: #2137 (comment)

#2137 (comment)

@majensen
Copy link
Member

@TomKellyGenetics - in the first paragraph of Methodology and software, there is a sentence:

...of the popular package, which is often used...

Seems like the package name is missing here, or I'm missing something.

@TomKellyGenetics
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 12, 2020

@TomKellyGenetics
Copy link

TomKellyGenetics commented Mar 12, 2020

This should build with updates from minor (formatting) corrections from errors found while submitting to CRAN and bioRxiv. I’ll look into removing unneeded references from the bibtex file. An updated submission with corrected documentation has been re-uploaded to CRAN and is pending manual confirmation.

@arfon
Copy link
Member

arfon commented Mar 14, 2020

Dear authors and reviewers

We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required.

Thanks in advance for your understanding.

Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team.

@TomKellyGenetics
Copy link

Dear Arfon,

Thank you for informing us on your policy. I'm currently based in Japan (which is considering to declare a state of emergency) so we're acutely aware of the developing situation here. I understand completely if reviews will take longer than usual during this time. I am safely able to work from home so can still respond to reviewers if they are able to.

Thank you,

Tom Kelly, Postdoctoral researcher at RIKEN IMS, Yokohama

@corybrunson
Copy link

@TomKellyGenetics the submission looks pretty cool, as i'm just starting my review. I have some comments on the paper before i begin exploring the software. Sorry if you've already caught some of these but not yet updated the PDF.

  • I think "Present address:" should be removed from the second affiliation (RIKEN).
  • On my reading, the abstract-style Statement of Need encapsulates what graphsim does but doesn't really justify it. This is taken care of in the Summary, so could the Statement of Need be excised? I know JOSS guidelines require a statement of need, but in my experience this does not need to be a separate section. (@majensen this is something i've wondered before. Does JOSS prefer the SoN to be a section with header?)
  • The paper could use a careful proofreading. For example, there is a stray curly brace after "R" in the Summary, and "released as the package" would read more clearly as "released as a package".
  • In the first paragraph of "Methodology and software", it's not clear to me whether the simulation procedure you've implemented is of your own design or is already widely used but not yet conveniently packaged. If it is the same procedure as that of Wang &al (2018), then it would be good to say this at the start.
  • Package names are not showing up in the paper.
  • The section cross-reference at the end of "Generating a Simulated Expression Dataset" is broken.

@corybrunson
Copy link

@TomKellyGenetics a couple of other comments, specifically on the code in the paper:

  • The gplots package is used but not explicitly attached to the library.
  • There's at least one typo: trace = "none\" toward the bottom of page 6.
  • I'm unable to exactly reproduce the heatmaps displayed in the paper. They're based on the graph with inhibitions, and i'm also not clear on how to incorporate the vector state into these calculations, after looking into the code only a slight bit. (For issues running examples, etc. in the package itself, i'll open issues on the GitHub repo.)

@corybrunson
Copy link

@TomKellyGenetics one last point on the paper:

  • The second author has not directly contributed to the package, as reflected on GitHub. Could you briefly describe their contributions to the project in the paper?

@rcannood
Copy link

Sorry for my late response, I didn't manage to find any spare time until now. @majensen I wanted to start the review just now, but I see I missed the opportunity to accept whedon's invitation to the repository. (I thought I had retained the rights since my previous review, but apparently they get removed after the review is done.) Could I somehow be invited again?

@TomKellyGenetics
Copy link

Thanks @corybrunson, I'll take a look at Issues as they come into the package repo (I think the problem with plot_directed is resolved).

I can reformat the Statement of Need if this is required explicitly by JOSS. I made it a separate section (as done by other recent submissions) so it would be clear for the editorial process.

Sorry it seems that some text formatting for language and package names weren't handled well when exporting LaTeX to whedon-compatible markdown. I've fixed these on the biorXiv version and I'll update the JOSS submission accordingly.

Wang et al (2018) also simulate gene expression counts as a log-normal distribution. This package was originally developed before this publication. The approach to simulate based on graph structures is our original design. To my knowledge, there are no pre-existing implementations for this procedure in R.

The second author is my PhD supervisor. He was involved in planning, overseeing the project and preparing the manuscript. He has tested the software and given feedback on it.

I'll update the PDF once I've corrected the issues mentioned with the markdown document.

@arfon
Copy link
Member

arfon commented Mar 23, 2020

@whedon re-invite @rcannood

@whedon
Copy link
Author

whedon commented Mar 23, 2020

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@arfon
Copy link
Member

arfon commented Mar 23, 2020

@whedon re-invite @rcannood as reviewer

@whedon
Copy link
Author

whedon commented Mar 23, 2020

OK, the reviewer has been re-invited.

@rcannood please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

@rcannood
Copy link

Thanks @arfon @whedon!

@majensen
Copy link
Member

Thanks @arfon; WB @rcannood !

@majensen
Copy link
Member

@corybrunson - my opinion as editor (which will be addressed by @arfon if I'm wrong) is that the paper should be sure to include the rationale for writing the software and why there is a niche for it. Not necessary to have a heading (personally, I think that would be stylistically gauche-- but that's only my opinion!).

@corybrunson
Copy link

corybrunson commented Mar 25, 2020

@TomKellyGenetics no problem, i'll come back to the PDF after the next update.

Regarding the Statement of Need, i'll be fine with the current formatting (above the Summary with its own header) if you want to keep it (thank you @majensen for your comment); my concern is that it says only what the software does, not what need it satisfies. The first three paragraphs of the Introduction do this quite well, so i'd suggest encapsulating them into 2 or 3 sentences for that purpose.

Onward to the software itself. : )

@whedon
Copy link
Author

whedon commented Jul 7, 2020

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#1550

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1550, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

@TomKellyGenetics
Copy link

@majensen Thanks, I agree to this change so I've pushed a correction.

i.e., "studies, as well as bulk...".

I think I've got this in time to be compiled in the final submission.

@majensen
Copy link
Member

majensen commented Jul 7, 2020

@openjournals/joss-eics We are ready to recommend this work for acceptance. Thanks!

@kyleniemeyer
Copy link

Hi @TomKellyGenetics, before accepting I found just a few things in the paper to fix:

  • typo in third sentence: "uesad" -> "used"
  • the limma reference has a a typo in the bib file, I think there is a space missing between a comma and and causing a problem:
{Matthew E R., and Phipson, B.,and Wu, D.,  and Hu, Y.,  and Law, C.W.,  and Shi, W., and Smyth, G.K.,}

should be

{Matthew E R., and Phipson, B., and Wu, D., and Hu, Y., and Law, C.W., and Shi, W., and Smyth, G.K.,}

TomKellyGenetics added a commit to TomKellyGenetics/graphsim that referenced this issue Jul 9, 2020
@TomKellyGenetics
Copy link

Thanks for letting me know @kyleniemeyer, the corrected version should be pushed now.

@TomKellyGenetics
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 9, 2020

@kyleniemeyer
Copy link

@TomKellyGenetics looks good!

@kyleniemeyer
Copy link

@whedon accept

@whedon
Copy link
Author

whedon commented Jul 9, 2020

Attempting dry run of processing paper acceptance...

@whedon
Copy link
Author

whedon commented Jul 9, 2020

Reference check summary:

OK DOIs

- 10.1038/nrg1272 is OK
- 10.1093/nar/gkt1102 is OK
- 10.1007/978-3-642-01689-9 is OK
- 10.3389/fgene.2019.00535 is OK
- 10.1093/imanum/22.3.329 is OK
- 10.1093/bioinformatics/btm639 is OK
- 10.1038/nrg.2016.87 is OK
- 10.3892/ijo.2012.1744 is OK
- 10.1186/gb-2014-15-2-r29 is OK
- 10.1186/s12859-015-0778-7 is OK
- 10.1186/1471-2105-8-s6-s5 is OK
- 10.1093/nar/gkv007 is OK
- 10.1038/nprot.2017.149 is OK
- 10.1038/nrg2934 is OK
- 10.1101/2020.02.06.936971 is OK
- 10.1101/716811 is OK
- 10.1186/1752-0509-3-41 is OK
- 10.1101/227033 is OK
- 10.1109/msp.2007.273053 is OK
- 10.1186/s13059-017-1305-0 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Jul 9, 2020

👋 @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof 👉 openjournals/joss-papers#1551

If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1551, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

@kyleniemeyer
Copy link

@whedon accept deposit=true

@whedon whedon added accepted published Papers published in JOSS labels Jul 9, 2020
@whedon
Copy link
Author

whedon commented Jul 9, 2020

Doing it live! Attempting automated processing of paper acceptance...

@whedon
Copy link
Author

whedon commented Jul 9, 2020

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

@whedon
Copy link
Author

whedon commented Jul 9, 2020

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.02161 joss-papers#1552
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02161
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@kyleniemeyer
Copy link

Congrats @TomKellyGenetics on your article's publication in JOSS!

Many thanks to @rcannood and @corybrunson for reviewing, and @majensen for editing.

@whedon
Copy link
Author

whedon commented Jul 9, 2020

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02161/status.svg)](https://doi.org/10.21105/joss.02161)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02161">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02161/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02161/status.svg
   :target: https://doi.org/10.21105/joss.02161

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

@majensen
Copy link
Member

majensen commented Jul 9, 2020

Really nice paper @TomKellyGenetics - @corybrunson and @rcannood I appreciate your huge contribution during these strange days. Hope you will all think of JOSS next time you publish!
--@majensen

@TomKellyGenetics
Copy link

Thanks again, @majensen @corybrunson and @rcannood, I'm very impressed by the JOSS review process. This a great initiative for the open-source community. I have put my name in the hat to review. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review
Projects
None yet
Development

No branches or pull requests

9 participants