-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: graphsim: An R package for simulating gene expression data from graph structures of biological pathways #2161
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @rcannood, @corybrunson it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Replicating @arfon comment here regarding trimming bibtex entries:
|
@TomKellyGenetics - in the first paragraph of Methodology and software, there is a sentence:
Seems like the package name is missing here, or I'm missing something. |
@whedon generate pdf |
This should build with updates from minor (formatting) corrections from errors found while submitting to CRAN and bioRxiv. I’ll look into removing unneeded references from the bibtex file. An updated submission with corrected documentation has been re-uploaded to CRAN and is pending manual confirmation. |
Dear authors and reviewers We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required. Thanks in advance for your understanding. Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team. |
Dear Arfon, Thank you for informing us on your policy. I'm currently based in Japan (which is considering to declare a state of emergency) so we're acutely aware of the developing situation here. I understand completely if reviews will take longer than usual during this time. I am safely able to work from home so can still respond to reviewers if they are able to. Thank you, Tom Kelly, Postdoctoral researcher at RIKEN IMS, Yokohama |
@TomKellyGenetics the submission looks pretty cool, as i'm just starting my review. I have some comments on the paper before i begin exploring the software. Sorry if you've already caught some of these but not yet updated the PDF.
|
@TomKellyGenetics a couple of other comments, specifically on the code in the paper:
|
@TomKellyGenetics one last point on the paper:
|
Sorry for my late response, I didn't manage to find any spare time until now. @majensen I wanted to start the review just now, but I see I missed the opportunity to accept whedon's invitation to the repository. (I thought I had retained the rights since my previous review, but apparently they get removed after the review is done.) Could I somehow be invited again? |
Thanks @corybrunson, I'll take a look at Issues as they come into the package repo (I think the problem with I can reformat the Statement of Need if this is required explicitly by JOSS. I made it a separate section (as done by other recent submissions) so it would be clear for the editorial process. Sorry it seems that some text formatting for language and package names weren't handled well when exporting LaTeX to whedon-compatible markdown. I've fixed these on the biorXiv version and I'll update the JOSS submission accordingly. Wang et al (2018) also simulate gene expression counts as a log-normal distribution. This package was originally developed before this publication. The approach to simulate based on graph structures is our original design. To my knowledge, there are no pre-existing implementations for this procedure in R. The second author is my PhD supervisor. He was involved in planning, overseeing the project and preparing the manuscript. He has tested the software and given feedback on it. I'll update the PDF once I've corrected the issues mentioned with the markdown document. |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
OK, the reviewer has been re-invited. @rcannood please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
@corybrunson - my opinion as editor (which will be addressed by @arfon if I'm wrong) is that the paper should be sure to include the rationale for writing the software and why there is a niche for it. Not necessary to have a heading (personally, I think that would be stylistically gauche-- but that's only my opinion!). |
@TomKellyGenetics no problem, i'll come back to the PDF after the next update. Regarding the Statement of Need, i'll be fine with the current formatting (above the Summary with its own header) if you want to keep it (thank you @majensen for your comment); my concern is that it says only what the software does, not what need it satisfies. The first three paragraphs of the Introduction do this quite well, so i'd suggest encapsulating them into 2 or 3 sentences for that purpose. Onward to the software itself. : ) |
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1550 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1550, then you can now move forward with accepting the submission by compiling again with the flag
|
@majensen Thanks, I agree to this change so I've pushed a correction.
I think I've got this in time to be compiled in the final submission. |
@openjournals/joss-eics We are ready to recommend this work for acceptance. Thanks! |
Hi @TomKellyGenetics, before accepting I found just a few things in the paper to fix:
should be
|
Thanks for letting me know @kyleniemeyer, the corrected version should be pushed now. |
@whedon generate pdf |
@TomKellyGenetics looks good! |
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1551 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1551, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats @TomKellyGenetics on your article's publication in JOSS! Many thanks to @rcannood and @corybrunson for reviewing, and @majensen for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Really nice paper @TomKellyGenetics - @corybrunson and @rcannood I appreciate your huge contribution during these strange days. Hope you will all think of JOSS next time you publish! |
Thanks again, @majensen @corybrunson and @rcannood, I'm very impressed by the JOSS review process. This a great initiative for the open-source community. I have put my name in the hat to review. 😊 |
Submitting author: @TomKellyGenetics (S. Thomas Kelly)
Repository: https://github.com/TomKellyGenetics/graphsim
Version: v1.0.0-joss
Editor: @majensen
Reviewer: @rcannood, @corybrunson
Archive: 10.5281/zenodo.3931288
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@rcannood & @corybrunson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @rcannood
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @corybrunson
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: