Skip to content

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Sep 5, 2025

Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt.
A testcase is included.
It is a clean backport.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #2154 as a prerequisite.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346465 needs maintainer approval
  • Change requires CSR request JDK-8367128 to be approved

Warnings

 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/builtIn.icc)
 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/BuiltInProfileCheck/custom.icc)

Issues

  • JDK-8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles (Bug - P3)
  • JDK-8367128: Add a check in setData() to restrict the update of Built-In ICC_Profiles (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2155/head:pull/2155
$ git checkout pull/2155

Update a local copy of the PR:
$ git checkout pull/2155
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2155

View PR using the GUI difftool:
$ git pr show -t 2155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2155.diff

Using Webrev

Link to Webrev Comment

Harshitha Onkar added 2 commits September 5, 2025 16:46
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2025

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into pr/2154 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3131dd1d5cb601b84cf898fff589596c2bcabdbc 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles Sep 5, 2025
@openjdk
Copy link

openjdk bot commented Sep 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 5, 2025
@openjdk
Copy link

openjdk bot commented Sep 5, 2025

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Sep 5, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2025

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2154 to master September 16, 2025 09:18
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8347377-8346465
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Sep 16, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2025

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base csr Pull request needs approved CSR before integration rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant