-
Notifications
You must be signed in to change notification settings - Fork 142
8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles #2155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewed-by: prr, jdv
…ICC_Profiles Reviewed-by: aivanov, jdv, prr, serb
👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout 8347377-8346465
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Built-in singleton ICC_Profiles could be modified using setData(). Throw an exception for such an attempt.
A testcase is included.
It is a clean backport.
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.
It requires #2154 as a prerequisite.
Progress
Warnings
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2155/head:pull/2155
$ git checkout pull/2155
Update a local copy of the PR:
$ git checkout pull/2155
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2155/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2155
View PR using the GUI difftool:
$ git pr show -t 2155
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2155.diff
Using Webrev
Link to Webrev Comment