8347377: Add validation checks for ICC_Profile header fields

[jankratochvil]

ICC_Profile header is validated too late leading later to unexpected exceptions.
A testcase is included.
It is a clean backport (except for copyright years).
This backport is authored by Anton Voznia, I am only submitting it. Anton Voznia is an Azul employee so he should be covered by Azul OCA. Anton Voznia has not signed a personal OCA from Oracle.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347377 needs maintainer approval

Warning

 ⚠️ Patch contains a binary file (test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData/invalidSRGB.icc)

Issue

• JDK-8347377: Add validation checks for ICC_Profile header fields (Bug - P3 - Approved)

Contributors

• Anton Voznia <avoznia@azul.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2154/head:pull/2154
$ git checkout pull/2154

Update a local copy of the PR:
$ git checkout pull/2154
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2154

View PR using the GUI difftool:
$ git pr show -t 2154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2154.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347377: Add validation checks for ICC_Profile header fields

Co-authored-by: Anton Voznia <avoznia@azul.com>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• adbacf1: 8364198: NMT should have a better corruption message
• b7e5f71: 8347434: Richer VM operations events logging
• 9a8a68d: 8318850: Duplicate code in the LCMSImageLayout
• ... and 53 more: https://git.openjdk.org/jdk21u-dev/compare/32d8d448361cedf7d0825b870054d167cacbc6b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (665f16c3)

[jankratochvil]

/author Anton Voznia avoznia@azul.com

[openjdk]

@jankratochvil Only Committers are allowed to issue the author command.

[alexeybakhtin]

/author Anton Voznia avoznia@azul.com

[openjdk]

@alexeybakhtin Only the pull request author (@jankratochvil) is allowed to issue the author command.

[jerboaa]

You can use the /contributor command to add Anton Voznia.

[jankratochvil]

/contributor Anton Voznia avoznia@azul.com

[openjdk]

@jankratochvil Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

• /contributor add @openjdk-bot
• /contributor add duke
• /contributor add J. Duke <duke@openjdk.org>

User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address.

[jankratochvil]

/contributor add Anton Voznia avoznia@azul.com

[openjdk]

@jankratochvil
Contributor Anton Voznia <avoznia@azul.com> successfully added.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 665f16c) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[jerboaa]

Next time Anton should submit his own PR. There is no need to have any role for initial contributions. This avoids the author issues.

[openjdk]

Going to push as commit 40d98b8.
Since your change was applied there have been 56 commits pushed to the master branch:

• adbacf1: 8364198: NMT should have a better corruption message
• b7e5f71: 8347434: Richer VM operations events logging
• 9a8a68d: 8318850: Duplicate code in the LCMSImageLayout
• ... and 53 more: https://git.openjdk.org/jdk21u-dev/compare/32d8d448361cedf7d0825b870054d167cacbc6b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @jankratochvil Pushed as commit 40d98b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jankratochvil]

Next time Anton should submit his own PR. There is no need to have any role for initial contributions. This avoids the author issues.

It would take some more time. Anton Voznia has submitted as himself: openjdk/jdk17u-dev#3936