Skip to content

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2025

I backport this to improve testing.

Resolved one chunk in Win8301247Test.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344275 needs maintainer approval

Integration blocker

 ⚠️ Dependency #4016 must be integrated first

Issue

  • JDK-8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4017/head:pull/4017
$ git checkout pull/4017

Update a local copy of the PR:
$ git checkout pull/4017
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4017

View PR using the GUI difftool:
$ git pr show -t 4017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4017.diff

Using Webrev

Link to Webrev Comment

@GoeLin GoeLin marked this pull request as draft October 5, 2025 19:23
@GoeLin GoeLin changed the base branch from master to pr/4015 October 5, 2025 19:23
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from pr/4015 to pr/4016 October 5, 2025 19:24
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the title Goetz backport 8344275 backport 227c430b55e7f9a4257b9249881c8ec75574895c Oct 5, 2025
@openjdk openjdk bot changed the title backport 227c430b55e7f9a4257b9249881c8ec75574895c 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform Oct 5, 2025
@openjdk
Copy link

openjdk bot commented Oct 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Oct 5, 2025
@GoeLin GoeLin marked this pull request as ready for review October 7, 2025 16:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 7, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 9, 2025

Thanks for the reviews!

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants