You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.
openjdkbot
changed the title
backport e1b5f3c56d02c6738726106d3d069fea7a633245
8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file
Oct 5, 2025
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.
⚠️@GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code baserfrPull request is ready for review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openjdk
bot
changed the title
GoeLin
force-pushed
the
goetz_backport_8343314
branch
from
I backport this to simplify later changes.
Backport is based on push to 21.
Skipped some more files, needed further resolves:
test/jdk/tools/jpackage/linux/ReleaseTest.java
Resolved @test block
test/jdk/tools/jpackage/macosx/SigningAppImageTest.java
test/jdk/tools/jpackage/macosx/SigningPackageTest.java
Copyright
test/jdk/tools/jpackage/share/AddLauncherTest.java
Resolved @test block
test/jdk/tools/jpackage/share/AppImagePackageTest.java
Copyright
test/jdk/tools/jpackage/share/IconTest.java
Resolved @test block
test/jdk/tools/jpackage/share/LicenseTest.java
Copyright
test/jdk/tools/jpackage/share/MultiLauncherTwoPhaseTest.java
Resolved @test block
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4016/head:pull/4016$ git checkout pull/4016Update a local copy of the PR:
$ git checkout pull/4016$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4016/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4016View PR using the GUI difftool:
$ git pr show -t 4016Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4016.diff
Using Webrev
Link to Webrev Comment