feat: allow custom nonce in OIDAuthorizationRequest #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit: I'm listed here so I believe the agreement signing part is done I signed the contributor agreement. According to https://github.com/openid/AppAuth-iOS/blob/master/CONTRIBUTING.md there's two to sign, but I only really saw one. Hope somebody's going to review this :D |
vonovak
changed the title
2 tasks
mdmathias
requested changes
Oct 4, 2023
|
@vonovak I will be OOO for about 1.5 weeks starting tomorrow. I promise to take a look when I am back. Thanks! |
mdmathias
requested changes
Oct 17, 2023
mdmathias
approved these changes
Oct 18, 2023
|
thanks for review and merge! 🙂 |
|
Absolutely, thanks for the contribution. :D |
HadesPTIT
pushed a commit
to HadesPTIT/AppAuth-iOS
that referenced
this pull request
Nov 14, 2023
…)" This reverts commit 8b437c4.
|
@mdmathias would you please share an ETA for the next release? I'd like to integrate this change into https://github.com/google/GoogleSignIn-iOS thank you |
|
We are currently working on adding a privacy manifest for this library, and the next release will be out before Spring 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is in response to this PR which has been opened ~ year ago and appears to be in a limbo
google/GoogleSignIn-iOS#244
The PR did get a review from @mdmathias who pointed out one issue here that seems to prevent the PR from getting merged.
There is a substantial community interest to get the PR merged and it appears there is willingness on the google side as well.
I'm attempting to unblock the PR by adding the initializer that is being asked for in the review comment (linked above).
Thank you in advance for your review