Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow providing custom nonce #402

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Apr 28, 2024

Uses: openid/AppAuth-iOS#788. Motivation is explained there and also in issue #135

Fixes: #135

Supersedes: #244. It takes a slightly different approach where nonce is not provided via GIDConfiguration but via a parameter to signInWithPresentingViewController/Window

Copy link

google-cla bot commented Apr 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mdmathias
Copy link
Collaborator

@vonovak did you sign the CLA? I can take a look at the PR after you confirm.

@vonovak
Copy link
Contributor Author

vonovak commented May 24, 2024

hello @mdmathias yes I did! :)

Screenshot 2024-05-24 at 20 07 10

@mdmathias mdmathias self-requested a review June 4, 2024 19:07
GoogleSignIn/Sources/GIDSignInInternalOptions.h Outdated Show resolved Hide resolved
GoogleSignIn/Sources/GIDSignInInternalOptions.h Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
@vonovak vonovak requested a review from mdmathias June 6, 2024 10:16
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated Show resolved Hide resolved
@vonovak vonovak requested a review from mdmathias July 16, 2024 08:22
@vonovak
Copy link
Contributor Author

vonovak commented Aug 6, 2024

hello @mdmathias, would you please re-review the PR? Thank you! 🙂

@GNUGradyn
Copy link

Can we get this merged? This issue is blocking my app

@NorseGaud
Copy link

Bumpziez

@mdmathias
Copy link
Collaborator

@vonovak could you take a look at the test failures? An example:

- WARN | xcodebuild: /Users/runner/work/GoogleSignIn-iOS/GoogleSignIn-iOS/GoogleSignIn/Tests/Unit/OIDAuthorizationRequest+Testing.h:23:17: warning: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Wnullability-completeness]

@vonovak
Copy link
Contributor Author

vonovak commented Aug 14, 2024

@mdmathias can you re-run the workflows? TY 🙂

@elyobo
Copy link

elyobo commented Aug 23, 2024

Tests all passing @mdmathias 👀

@vonovak
Copy link
Contributor Author

vonovak commented Sep 5, 2024

@mdmathias may I ask if there's anything blocking this PR from merging? The discussion is resolved and CI is green.
Is there anything we're waiting for?
Thank you

@mdmathias mdmathias merged commit b34f5a9 into google:main Sep 13, 2024
12 checks passed
@vonovak vonovak deleted the feat/custom-nonce branch September 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to pass in nonce?
5 participants