-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow providing custom nonce #402
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f81e466
to
699a005
Compare
@vonovak did you sign the CLA? I can take a look at the PR after you confirm. |
hello @mdmathias yes I did! :) |
hello @mdmathias, would you please re-review the PR? Thank you! 🙂 |
Can we get this merged? This issue is blocking my app |
Bumpziez |
@vonovak could you take a look at the test failures? An example:
|
@mdmathias can you re-run the workflows? TY 🙂 |
Tests all passing @mdmathias 👀 |
@mdmathias may I ask if there's anything blocking this PR from merging? The discussion is resolved and CI is green. |
Uses: openid/AppAuth-iOS#788. Motivation is explained there and also in issue #135
Fixes: #135
Supersedes: #244. It takes a slightly different approach where nonce is not provided via GIDConfiguration but via a parameter to
signInWithPresentingViewController/Window