Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from cv32e40p/dev to cv32e40p/release #584

Conversation

strichmo
Copy link
Contributor

@strichmo strichmo commented May 5, 2021

rel_check has been run

@strichmo strichmo requested a review from MikeOpenHWGroup May 5, 2021 15:41
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will merge pending a local ci_check regression.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 50cac35 into openhwgroup:cv32e40p/release May 5, 2021
@strichmo strichmo deleted the cv32e40p/merge_dev_to_rel_5 branch May 24, 2021 19:46
JeanRochCoulon pushed a commit to JeanRochCoulon/core-v-verif that referenced this pull request Feb 10, 2022
According to IEEE 1800-2017 (9.2.2.4 Sequential logic always_ff procedure):

"Variables on the left-hand side of assignments within an always_ff procedure, including variables from the contents of a called function, shall not be written to by any other process."
Thus there is a proposal of changing always_ff with always because Mem_DP is driven by two processes: initial and always_ff what is forbidden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants