Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates for easier Embench runs (+ some coremark/matmul_32b_float improvements) #2372

Conversation

pascalgouedo
Copy link

No description provided.

Pascal Gouedo added 7 commits February 20, 2024 14:46

Unverified

This user has not yet uploaded their public signing key.
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
…rmances.

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
Replacement of TB timer by internal cycle counter to be platform independent.

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
Additional updates to run multiple Embench runs in parallel (different configs, sequential or parallel mode).

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
…mances.

Signed-off-by: Pascal Gouedo <pascal.gouedo@dolphin.fr>
@pascalgouedo pascalgouedo added Common Infrastructure Library components or scriptware common to all environments in CORE-V-VERIF enhancement New feature or request cv32e40p labels Feb 20, 2024
Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only two files are non-embench-test specific (mk/Common.mk and mk/uvmt/uvmt.mk) and these changes look good.

I will defer to others who are more familiar with Embench to give the final approval and merge. Unfortunately, that is probably Marton Teilgard who is no longer at SiLabs. @silabs-hfegran, can you have a look?

@pascalgouedo pascalgouedo changed the title Some updates for easier Embench runs Some updates for easier Embench runs (+ some coremark/matmul_32b_float improvements) Feb 20, 2024
Copy link
Contributor

@silabs-hfegran silabs-hfegran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I have one question wrt. random bus stalls that I would like answered before approving this PR

cv32e40p/tests/embench/pylib/run_corev32.py Show resolved Hide resolved
@silabs-hfegran silabs-hfegran merged commit cad5e5b into openhwgroup:cv32e40p/dev Feb 22, 2024
1 check passed
@pascalgouedo pascalgouedo deleted the cv32e40p/dev_dd_pgo_embench branch February 22, 2024 11:01
@MikeOpenHWGroup
Copy link
Member

@silabs-hfegran said:

Looks good to me, but I have one question wrt. random bus stalls that I would like answered before approving this PR

Did @pascalgouedo answer your question Henrik?

@pascalgouedo
Copy link
Author

Hi @MikeOpenHWGroup
If you open Show resolved you will see both my answer and Henrik approval 😀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Infrastructure Library components or scriptware common to all environments in CORE-V-VERIF cv32e40p enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants