Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Replace react-helmet with react-helmet-async #22

Closed
LoneRifle opened this issue Aug 3, 2021 · 0 comments · Fixed by #429
Closed

Replace react-helmet with react-helmet-async #22

LoneRifle opened this issue Aug 3, 2021 · 0 comments · Fixed by #429
Assignees

Comments

@LoneRifle
Copy link
Contributor

react-helmet no longer works well with React 16, using the deprecated UNSAFE_componentWillMount (see nfl/react-helmet#548). The library is no longer maintained by the NFL, and has been dropped by the community in favour of react-helmet-async, written by @staylor of the NYT.

Work will chiefly centre around the following:

<Helmet>
<title>{title ? title : defaultTitle}</title>
</Helmet>

@LinHuiqing LinHuiqing self-assigned this Sep 30, 2021
LinHuiqing added a commit that referenced this issue Sep 30, 2021
- uninstall react-helmet and @types/react-helmet
- install react-helmet-async
- update index.js
and PageTitle for migration

re #22
LinHuiqing added a commit that referenced this issue Sep 30, 2021
- uninstall react-helmet and @types/react-helmet
- install react-helmet-async
- update index.js and PageTitle for migration

re #22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants