EWPP-3912: Adapt site and page header templates. #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-3912
branch
from
d9c5468 to
70da306
Compare
22Alexandra
force-pushed
the
EWPP-3882
branch
from
b8d97b5 to
fb717de
Compare
22Alexandra
force-pushed
the
EWPP-3912
branch
2 times, most recently
from
16ac324 to
2e980e6
Compare
22Alexandra
force-pushed
the
EWPP-3882
branch
from
6e50af1 to
0406504
Compare
22Alexandra
force-pushed
the
EWPP-3912
branch
from
0f442b0 to
85c4c64
Compare
nagyad
requested changes
Jan 24, 2024
| $icon = $language_switcher_button->find('css', "span.ecl-site-header__language-icon svg.ecl-icon.ecl-icon--s.ecl-site-header__icon[focusable='false'][aria-hidden='true']"); | ||
| $this->assertEquals('<use xlink:href="/build/themes/custom/oe_theme/dist/' . $component . '/images/icons/sprites/icons.svg#global" xmlns:xlink="http://www.w3.org/1999/xlink"></use>', $icon->getHtml()); | ||
| $this->assertEquals('English', $language_switcher_button->getText()); | ||
| file_put_contents('test.html', $this->getSession()->getPage()->getOuterHtml()); |
There was a problem hiding this comment.
@22Alexandra yep, let's remove this if not needed.
22Alexandra
force-pushed
the
EWPP-3912
branch
from
85c4c64 to
56b29e3
Compare
ademarco
reviewed
Jan 30, 2024
| label: 'Close' | ||
| icon_name: 'close-filled' | ||
| icon_size: 'm' | ||
| hide_label: false |
There was a problem hiding this comment.
This changes the API of this particular pattern, could we, instead, hide the change in the pattern implementation, so that preview stays Close and then we add that array in the pattern itself. The button is just the close button anyway, we can only offer the possibility to change its label.
| icon: { | ||
| path: ecl_icon_path, | ||
| name: close.icon_name, | ||
| size: close.icon_size, |
There was a problem hiding this comment.
See comment above, here just hard code values for the close button and leave only the label to be customizable.
| $icon = $language_switcher_button->find('css', "span.ecl-site-header__language-icon svg.ecl-icon.ecl-icon--s.ecl-site-header__icon[focusable='false'][aria-hidden='true']"); | ||
| $this->assertEquals('<use xlink:href="/build/themes/custom/oe_theme/dist/' . $component . '/images/icons/sprites/icons.svg#global" xmlns:xlink="http://www.w3.org/1999/xlink"></use>', $icon->getHtml()); | ||
| $this->assertEquals('English', $language_switcher_button->getText()); | ||
| file_put_contents('test.html', $this->getSession()->getPage()->getOuterHtml()); |
There was a problem hiding this comment.
@22Alexandra yep, let's remove this if not needed.
ademarco
previously approved these changes
Jan 30, 2024
22Alexandra
force-pushed
the
EWPP-3912
branch
from
bb06dfc to
5ad58e8
Compare
ademarco
approved these changes
Jan 31, 2024
nagyad
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.