EWPP-3912: Update navigation menu pattern.

openeuropa · Jan 31, 2024 · 5ad58e8 · 5ad58e8
1 parent 4819fa2
commit 5ad58e8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/templates/patterns/navigation_menu/navigation_menu.ui_patterns.yml b/templates/patterns/navigation_menu/navigation_menu.ui_patterns.yml
@@ -19,12 +19,9 @@ navigation_menu:
     close:
       type: "array"
       label: "Close button"
-      description: "Close button label and whether only an icon should be displayed."
       preview:
         label: 'Close'
-        icon_name: 'close-filled'
-        icon_size: 'm'
-        hide_label: false
+      description: "Close button label and whether only an icon should be displayed."
     back:
       type: "text"
       label: "Back button"

diff --git a/templates/patterns/navigation_menu/pattern-navigation-menu.html.twig b/templates/patterns/navigation_menu/pattern-navigation-menu.html.twig
@@ -75,10 +75,10 @@
       label: close.label|default('Close'|t),
       icon: {
         path: ecl_icon_path,
-        name: close.icon_name,
-        size: close.icon_size,
+        name: 'close-filled',
+        size: 'm',
       },
-      hide_label: close.hide_label|default(false)
+      hide_label: false
     },
     back_label: back|default('Back'|t),
     icon_path: ecl_icon_path,

diff --git a/tests/src/Kernel/fixtures/rendering.yml b/tests/src/Kernel/fixtures/rendering.yml
@@ -3091,7 +3091,7 @@
       "a.ecl-link--standalone.ecl-button.ecl-button--tertiary.ecl-menu__open.ecl-link--icon-only": 1
     equals:
       'a.ecl-menu__open.ecl-link--icon-only span.ecl-link__label': 'Menu'
-      '.ecl-menu__inner-header button.ecl-menu__close[data-ecl-menu-close]': "Close"
+      '.ecl-menu__inner-header button.ecl-menu__close[data-ecl-menu-close] span.ecl-button__label': "Close"
       '.ecl-menu__inner-header button.ecl-menu__back[data-ecl-menu-back] .ecl-button__label': "Back"
       'li.ecl-menu__item.ecl-menu__item--has-children:nth-child(1) a.ecl-menu__link': "Parent 1"
       'li.ecl-menu__item.ecl-menu__item--has-children:nth-child(2) a.ecl-menu__link': "Parent 2"
@@ -3140,7 +3140,7 @@
       "li.ecl-menu__item:nth-child(1) button[aria-label=\"Access item's children\"]": 1
     equals:
       '.ecl-menu__open .ecl-link__label': "Custom Menu"
-      '.ecl-menu__inner-header button.ecl-menu__close[data-ecl-menu-close]': "Close"
+      '.ecl-menu__inner-header button.ecl-menu__close[data-ecl-menu-close] span.ecl-button__label': "Close"
       '.ecl-menu__inner-header button.ecl-menu__back[data-ecl-menu-back] .ecl-button__label': "Back"
       'li.ecl-menu__item:nth-child(1) a.ecl-menu__link': "Parent 1"
       'li.ecl-menu__item:nth-child(1) ul.ecl-menu__sublist li.ecl-menu__subitem:nth-child(1) a.ecl-menu__sublink': 'Child 1.1'