EWPP-2706: Make sure featured media title is not printed when field is empty.

modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php

@@ -88,17 +88,28 @@ public function getLabel() {
    * {@inheritdoc}
    */
   public function viewElements(ContentEntityInterface $entity) {
-    // Display event description using "text_featured_media" pattern.
     $build = [
       '#type' => 'pattern',
       '#id' => 'text_featured_media',
-      '#fields' => [
-        'title' => $this->getRenderableTitle($entity),
-        'text' => $this->getRenderableText($entity),
-      ],
     ];
-
+    // If we have no renderable text and image we don't need a title.
+    $text = $this->getRenderableText($entity);
+    $title = $this->getRenderableTitle($entity);
     $this->addFeaturedMediaThumbnail($build, $entity);
+    $title = !empty($text[0]['#text']) || isset($build['#fields']['image']) ? $title : '';
+
+    // If we don't have a title we do not render anything because there is
+    // no text and no image.
+    if (empty($title)) {
+      // Make sure we continue to carry over the cache tags.
+      CacheableMetadata::createFromRenderArray($build)
+        ->merge(CacheableMetadata::createFromRenderArray($text))
+        ->applyTo($build);
+      return $build;
+    }
+
+    $build['#fields']['title'] = $title;
+    $build['#fields']['text'] = $text;
 
     return $build;
   }

tests/src/Functional/ContentEventRenderTest.php

@@ -496,9 +496,22 @@ public function testEventRendering(): void {
     $this->assertSession()->linkNotExistsExact('Main link for media items');
     $this->assertSession()->pageTextNotContains('More media links');
 
-    // Assert "Full text", "Featured media", "Featured media legend" fields
-    // (these fields have to be filled all together).
+    // Assert "Description" title is not rendered unless there is a body text.
+    $this->assertSession()->pageTextNotContains('Description');
+
+    // Assert "Full text", "Featured media", "Featured media legend" fields.
     $node->set('body', 'Event full text');
+    $node->save();
+    $this->drupalGet($node->toUrl());
+
+    $description_content = $this->assertSession()->elementExists('css', 'article > div > div:nth-child(3)');
+    $text_featured = new TextFeaturedMediaAssert();
+    $text_featured_expected_values = [
+      'title' => 'Description',
+      'text' => 'Event full text',
+    ];
+    $text_featured->assertPattern($text_featured_expected_values, $description_content->getHtml());
+
     $node->set('oe_event_featured_media_legend', 'Event featured media legend');
     $media_image = $this->createMediaImage('event_featured_media');
     $node->set('oe_event_featured_media', [$media_image])->save();