EWPP-2706: Make sure featured media title is not printed when field is empty. #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
requested changes
Oct 25, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Outdated
Show resolved
Hide resolved
sergepavle
requested changes
Oct 25, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Outdated
Show resolved
Hide resolved
sergepavle
previously approved these changes
Oct 27, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Outdated
Show resolved
Hide resolved
22Alexandra
requested changes
Oct 27, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Show resolved
Hide resolved
nagyad
force-pushed
the
EWPP-2706
branch
2 times, most recently
from
01fd577 to
547b0f8
Compare
22Alexandra
previously approved these changes
Oct 28, 2022
sergepavle
previously approved these changes
Oct 28, 2022
upchuk
requested changes
Nov 7, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Show resolved
Hide resolved
| // If we don't have a title we do not render anything because there is | ||
| // no text and no image. | ||
| if (empty($title)) { | ||
| return []; |
There was a problem hiding this comment.
getRenderableText() and getRenderableTitle() add cache tags. So here you essentially kill all those cache tags.
upchuk
requested changes
Nov 8, 2022
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/DescriptionExtraField.php
Show resolved
Hide resolved
22Alexandra
approved these changes
Nov 10, 2022
sergepavle
approved these changes
Nov 10, 2022
upchuk
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.