Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node16 support #236

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Node16 support #236

merged 1 commit into from
Apr 7, 2022

Conversation

aht007
Copy link
Member

@aht007 aht007 commented Mar 24, 2022

No description provided.

@aht007 aht007 force-pushed the node16-support branch 2 times, most recently from 9b8dfae to 3b3dbfb Compare March 24, 2022 13:28
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #236 (cbe98c2) into master (01583af) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   82.65%   82.47%   -0.18%     
==========================================
  Files          80       79       -1     
  Lines        1753     1735      -18     
  Branches      418      414       -4     
==========================================
- Hits         1449     1431      -18     
  Misses        303      303              
  Partials        1        1              
Impacted Files Coverage Δ
src/users/data/api.js 98.13% <0.00%> (-0.13%) ⬇️
src/index.jsx 0.00% <0.00%> (ø)
src/users/data/urls.js 100.00% <0.00%> (ø)
src/users/account-actions/v2/PasswordHistory.jsx
src/users/enrollments/v2/Enrollments.jsx
src/users/enrollments/v2/CreateEnrollmentForm.jsx
src/users/entitlements/v2/Entitlements.jsx
src/supportHome/SupportHomePage.jsx
src/users/v2/CopyShowHyperLinks.jsx
src/users/v2/SingleSignOnRecords.jsx
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01583af...cbe98c2. Read the comment docs.

Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@aht007 aht007 force-pushed the node16-support branch 7 times, most recently from f675d06 to a7242f2 Compare April 7, 2022 06:45

- name: Setup npm
run: npm install -g npm@6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to dependency conflicts during installations with Npm 8.6.0 as mentioned in this Issue we are pinning it to 8.5.x for now

Copy link
Contributor

@Ali-D-Akbar Ali-D-Akbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aht007 aht007 merged commit ddf4790 into master Apr 7, 2022
@aht007 aht007 deleted the node16-support branch April 7, 2022 12:23
ansabgillani pushed a commit that referenced this pull request Apr 27, 2022
ansabgillani pushed a commit that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants