build: Added support for node v16

[edx-requirements-bot]

Node upgrade phase 1 PR: doc with details

https://openedx.atlassian.net/wiki/spaces/AC/pages/3318054984/Node+16+Upgrade

Additional information from script execution

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran

modernize_node_workflow

The following packages were installed:
edx-repo-tools

[codecov]

Codecov Report

Merging #218 (4c6e4bc) into master (c741481) will not change coverage.
The diff coverage is n/a.

❗ Current head 4c6e4bc differs from pull request most recent head 591405f. Consider uploading reports for the commit 591405f to get more accurate results

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files          96       96           
  Lines        2247     2247           
  Branches      503      503           
=======================================
  Hits         1955     1955           
  Misses        292      292           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c741481...591405f. Read the comment docs.

[aht007]

check-prop-types@1.1.2 pins prop-types@"<=15.6.0" but @edx/frontend-platform@"^1.15.2" needs prop-types@"^15.7.2" due to which dependency conflict is arising and we can't update the dependencies for now

[binodpant]

check-prop-types@1.1.2 pins prop-types@"<=15.6.0" but @edx/frontend-platform@"^1.15.2" needs prop-types@"^15.7.2" due to which dependency conflict is arising and we can't update the dependencies for now

@aht007 do we have any ideas for next steps to fix this? Will we need to first update check-prop-types here?

[aht007]

@binodpant check-prop-types@1.1.2 is the latest version and hence we cannot update that. Also frontend-platform doesn't use this package and hence it has no such constraint. Updating dependencies is optional and we can skip it for now.

[Jawayria]

@aht007 we can skip npm update for now but please upgrade versions of edx-owned dependencies in this package like frontend-platform, paragon and frontend-build.

[aht007]

Hey @openedx/incident-management, I need your help in fixing the tests here for Node16 Upgrade. Card.Title, Card.SubTitle and related components have been removed in Newer versions of edx/Paragon due to which we had to make some changes to the codebase which fixed majority of the failing tests but there are still some tests that need to be modified itself due to these changes. Node Upgrade is a priority task and I would love to get you people involved in this and fix the tests as soon as possible.

[binodpant]

hmm... I see some failures like this

 Expected: "Copy✓ "
    Received: "Copy✓in a new tab"

this looks like an actual change in the rendered contents so may need to be fixed for this PR to approve? Alternatively it may be an ok change and tests need updates, but that is unlikely. I do not know the details of the paragon changes but do you have at least one screenshot maybe that can help us see what changed in the area of the UI that this test covers?

@mraarif @Jawayria

[binodpant]

The only ref I can see to the text in paragon is an alternative text option in the MailtoLink

https://github.com/openedx/paragon/blob/f58f8d24e9d07f1375ca045693f45169a9c90bec/src/MailtoLink/index.jsx#L63

checking to see if it can be related

[aht007]

@binodpant The owning team doesn't want to upgrade Paragon right away in this PR as currently v12.8 is being used here in this repo and v19.6 is a big jump and has a lot of change-set. Also the owning team has a separate ticket in their backlog to upgrade Paragon. We have made a separate PR which is adding Node upgrade without upgrading the packages that cause issues. The said PR has been tested locally and it works fine with Node16 so we will be going ahead with that PR and leave the dependencies upgrade on owning team

[aht007]

Closed in favor of PR