Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resyncing Master with open-release/olive.master #1000

Merged

Conversation

ghassanmas
Copy link
Member

@arbrandes This PR does update olive.master.
Initially I wanted to backport just the dynamic config, but I found all other commits are related to fixes, so I picked up all of them. i.e merged olive.master with master

xitij2000 and others added 11 commits October 12, 2022 17:57
…penedx#968)

To enable grouping by subsection in the discussions MFE, this PR updates
the embed URL to the one that supports grouping.

ref: openedx/frontend-app-discussions#281
Translates the rectangles for current and passing
grades when to appear on the right when in RTL.
Allows frontend-app-learning to be configured at
runtime using the LMS's new MFE Configuration API.

Part of openedx/wg-frontend#103
Currently expiring soon is displayed 28 days before expiration
and forever afterwards. Adds an actual expired state for after.

Also clarifies the expring soon message which assumed other course,
that was not necessarily true.

Also updates the take action lines when you do not have valid
onboarding to make sure they appear for everything not currently valid
or in process, and updates the submitted process lines to not appear
for expired statuses.
Mirrors the background image used in the new user tour modal
as it obstructs the readability of the modal title when in RTL
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 12, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 84.17% // Head: 84.21% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (57d880d) compared to base (1892eda).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           open-release/olive.master    #1000      +/-   ##
=============================================================
+ Coverage                      84.17%   84.21%   +0.03%     
=============================================================
  Files                            264      264              
  Lines                           4518     4541      +23     
  Branches                        1157     1167      +10     
=============================================================
+ Hits                            3803     3824      +21     
- Misses                           695      697       +2     
  Partials                          20       20              
Impacted Files Coverage Δ
src/course-home/outline-tab/messages.js 100.00% <ø> (ø)
...ourseware/course/sequence/content-lock/messages.js 100.00% <ø> (ø)
src/index.jsx 0.00% <ø> (ø)
...wUserCourseHomeTour/NewUserCourseHomeTourModal.jsx 100.00% <ø> (ø)
src/alerts/course-start-alert/CourseStartAlert.jsx 100.00% <100.00%> (ø)
...ine-tab/alerts/course-end-alert/CourseEndAlert.jsx 100.00% <100.00%> (ø)
...e-home/outline-tab/widgets/ProctoringInfoPanel.jsx 97.91% <100.00%> (+0.24%) ⬆️
...ess-tab/course-completion/CompletionDonutChart.jsx 100.00% <100.00%> (ø)
...ss-tab/grades/course-grade/CurrentGradeTooltip.jsx 94.44% <100.00%> (+0.32%) ⬆️
...home/progress-tab/grades/course-grade/GradeBar.jsx 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@arbrandes arbrandes merged commit 77e3b17 into openedx:open-release/olive.master Nov 14, 2022
@openedx-webhooks
Copy link

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants