-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resyncing Master with open-release/olive.master #1000
Resyncing Master with open-release/olive.master #1000
Conversation
…penedx#968) To enable grouping by subsection in the discussions MFE, this PR updates the embed URL to the one that supports grouping. ref: openedx/frontend-app-discussions#281
Translates the rectangles for current and passing grades when to appear on the right when in RTL.
Allows frontend-app-learning to be configured at runtime using the LMS's new MFE Configuration API. Part of openedx/wg-frontend#103
Currently expiring soon is displayed 28 days before expiration and forever afterwards. Adds an actual expired state for after. Also clarifies the expring soon message which assumed other course, that was not necessarily true. Also updates the take action lines when you do not have valid onboarding to make sure they appear for everything not currently valid or in process, and updates the submitted process lines to not appear for expired statuses.
Mirrors the background image used in the new user tour modal as it obstructs the readability of the modal title when in RTL
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportBase: 84.17% // Head: 84.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## open-release/olive.master #1000 +/- ##
=============================================================
+ Coverage 84.17% 84.21% +0.03%
=============================================================
Files 264 264
Lines 4518 4541 +23
Branches 1157 1167 +10
=============================================================
+ Hits 3803 3824 +21
- Misses 695 697 +2
Partials 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@arbrandes This PR does update olive.master.
Initially I wanted to backport just the dynamic config, but I found all other commits are related to fixes, so I picked up all of them. i.e merged olive.master with master