expired onboarding exam messaging fix #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashultz0
force-pushed
the
ashultz0/proctoring-expiring
branch
3 times, most recently
from
327fb3c
to
055f611
Compare
Codecov ReportBase: 84.13% // Head: 84.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 84.13% 84.20% +0.06%
==========================================
Files 264 264
Lines 4519 4539 +20
Branches 1158 1166 +8
==========================================
+ Hits 3802 3822 +20
Misses 697 697
Partials 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ashultz0
force-pushed
the
ashultz0/proctoring-expiring
branch
from
2cae16b
to
29dd049
Compare
ashultz0
changed the title
5 tasks
alangsto
approved these changes
Nov 2, 2022
| @@ -77,11 +83,19 @@ function ProctoringInfoPanel({ intl }) { | |||
| return borderClass; | |||
| } | |||
|
|
|||
| function isExpired(dateString) { | |||
| // Returns true if the expiration date is within 28 days | |||
There was a problem hiding this comment.
Should update this comment for expired, not expiring soon
Currently expiring soon is displayed 28 days before expiration and forever afterwards. Adds an actual expired state for after. Also clarifies the expring soon message which assumed other course, that was not necessarily true. Also updates the take action lines when you do not have valid onboarding to make sure they appear for everything not currently valid or in process, and updates the submitted process lines to not appear for expired statuses.
ashultz0
force-pushed
the
ashultz0/proctoring-expiring
branch
from
29dd049
to
d63ebe2
Compare
mattcarter
approved these changes
Nov 2, 2022
arbrandes
pushed a commit
that referenced
this pull request
Nov 14, 2022
Currently expiring soon is displayed 28 days before expiration and forever afterwards. Adds an actual expired state for after. Also clarifies the expring soon message which assumed other course, that was not necessarily true. Also updates the take action lines when you do not have valid onboarding to make sure they appear for everything not currently valid or in process, and updates the submitted process lines to not appear for expired statuses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently expiring soon is displayed 28 days before expiration and forever afterwards. Adds an actual expired state for after.
Also clarifies the expring soon message which assumed other course, that was not necessarily true.
Also updates the take action lines when you do not have valid onboarding to make sure they appear for everything not currently valid or in process, and updates the submitted process lines to not appear for expired statuses.
This also requires expiration time updates provided in openedx/edx-proctoring#1088 to make sure that expiration time properly comes along with more exam states.