feat: read from fixed priced usd for course sidebar #1201
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
getCoursePrice
to read fromfixedPriceUsd
if it exists.Since the listPrice which is defined upstream of getCoursePrice is defined by the listPrice.usd value from canRedeem, no further changes are needed in the frontend to ensure that the fixed price is displayed if it exists. This is because the source of truth for price (
NormalizedContentMetadataSerializer.get_content_price
[source]) has been updated to readfixed_price_usd
if it exist, and propogates to thelistPrice.usd
downstream within canRedeem once these PRs are merged.[Bug fix]
Fixed a bug I ran into where the subscription expiration modal became a blocking modal.
For all changes
Only if submitting a visual change