feat: Add fixed_price_usd logic to normalized metadata content price #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brobro10000
force-pushed
the
hu/ent-9029
branch
3 times, most recently
from
49946b7
to
9db81ef
Compare
brobro10000
commented
Sep 9, 2024
brobro10000
force-pushed
the
hu/ent-9029
branch
from
9db81ef
to
9431fb6
Compare
brobro10000
commented
Sep 9, 2024
Comment on lines
139
to
158
| @extend_schema_field(serializers.FloatField) | ||
| def get_content_price(self, obj) -> float: | ||
| if obj.is_exec_ed_2u_course: | ||
| for entitlement in obj.json_metadata.get('entitlements', []): | ||
| if entitlement.get('mode') == CourseMode.PAID_EXECUTIVE_EDUCATION: | ||
| return entitlement.get('price') or DEFAULT_NORMALIZED_PRICE | ||
|
|
||
| if not self.advertised_course_run: | ||
| def get_content_price(self, obj) -> float: # pylint: disable=unused-argument | ||
| if not self.course_run_metadata: | ||
| return None | ||
|
|
||
| return self.advertised_course_run.get('first_enrollable_paid_seat_price') or DEFAULT_NORMALIZED_PRICE | ||
| if self.course_run_metadata.get('fixed_price_usd'): | ||
| return float(self.course_run_metadata.get('fixed_price_usd')) | ||
| if self.course.is_exec_ed_2u_course: | ||
| for entitlement in self.course_metadata.get('entitlements', []): | ||
| if entitlement.get('price') and entitlement.get('mode') == CourseMode.PAID_EXECUTIVE_EDUCATION: | ||
| return float(entitlement.get('price')) | ||
| if self.course_run_metadata.get('first_enrollable_paid_seat_price'): | ||
| return float(self.course_run_metadata.get('first_enrollable_paid_seat_price')) | ||
| return DEFAULT_NORMALIZED_PRICE |
There was a problem hiding this comment.
Since the introduction of normalized_metadata_by_run was included in #930. Majority of the work in this PR centers around updating get_content_price and adding corresponding tests.
Refactored function to respect expected output type of float and to handle None types gracefully as demonstrated by the tests with a deterministic output that can be tested based on the three price fields and their typing:
first_enrollable_paid_seat_price-intfixed_price_usd-strprice-str
The newly added test for get_content_price also replicate current typing behavior
This was referenced Sep 9, 2024
brobro10000
force-pushed
the
hu/ent-9029
branch
from
9431fb6
to
c9f50e6
Compare
iloveagent57
approved these changes
Sep 10, 2024
4 tasks
brobro10000
force-pushed
the
hu/ent-9029
branch
2 times, most recently
from
e5856cd
to
8f899bd
Compare
brobro10000
force-pushed
the
hu/ent-9029
branch
from
8f899bd
to
a745a52
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considers a course run's
fixed_price_usdvalue as part of theget_content_priceserializer fornormalized_metadataand upcomingnormalized_metadata_by_run.PR includes dependent changes from this PR -> #930
Refactors
get_content_priceto respectfloattype output and to handleNonetype prices gracefully based on the unique incoming data types betweenfirst_enrollable_paid_seat_priceandfixed_price_usd/priceAdds tests for
get_content_pricefor theNormalizedContentMetadataSerializerTests.Post-review