Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update course about sidebar to take into account usd fixed price #1199

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Sep 25, 2024

This change would take into account price ranges for the course sidebar based on the run price. 👍🏽

Example UI:
Screenshot 2024-10-02 at 9 58 02 AM

[Bug fix]
Fixed a bug I ran into where the subscription expiration modal became a blocking modal.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@brobro10000 brobro10000 force-pushed the hu/ent-9395 branch 4 times, most recently from ddb5e92 to d1b7ac8 Compare September 26, 2024 14:53
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (f7bcbfe) to head (5fb9002).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...s/app/data/hooks/useCourseRedemptionEligibility.js 80.00% 2 Missing ⚠️
src/components/course/data/utils.jsx 87.50% 2 Missing ⚠️
src/utils/common.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.02%     
==========================================
  Files         396      399       +3     
  Lines        8407     8500      +93     
  Branches     2059     2093      +34     
==========================================
+ Hits         7434     7515      +81     
- Misses        930      942      +12     
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 marked this pull request as ready for review September 30, 2024 17:08
src/components/course/CourseSidebarPrice.jsx Outdated Show resolved Hide resolved
src/components/course/data/hooks.jsx Outdated Show resolved Hide resolved
src/components/course/data/hooks.jsx Outdated Show resolved Hide resolved
src/components/course/data/tests/hooks.test.jsx Outdated Show resolved Hide resolved
src/components/course/data/tests/hooks.test.jsx Outdated Show resolved Hide resolved
src/components/microlearning/VideoDetailPage.jsx Outdated Show resolved Hide resolved
src/utils/common.js Outdated Show resolved Hide resolved
src/utils/common.js Outdated Show resolved Hide resolved
const seenExpiredSubscriptionModal = !!global.localStorage.getItem(
EXPIRED_SUBSCRIPTION_MODAL_LOCALSTORAGE_KEY(subscriptionLicense),
);
const [isOpen, , close] = useToggle(!seenExpiredSubscriptionModal);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌

src/components/course/data/tests/hooks.test.jsx Outdated Show resolved Hide resolved
src/components/course/data/tests/hooks.test.jsx Outdated Show resolved Hide resolved
src/components/course/data/utils.jsx Outdated Show resolved Hide resolved
src/components/course/data/utils.jsx Outdated Show resolved Hide resolved
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 addtl comment, around the rename from coursePrice.discountedList -> coursePrice.discountedListRange.

src/components/course/data/hooks.jsx Outdated Show resolved Hide resolved
@brobro10000 brobro10000 merged commit bcfbe24 into master Oct 8, 2024
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-9395 branch October 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants