chore: PR feedback 2

src/components/app/data/hooks/useCourseRedemptionEligibility.js

@@ -6,11 +6,11 @@ import { queryCanRedeem } from '../queries';
 import useEnterpriseCustomer from './useEnterpriseCustomer';
 import useLateEnrollmentBufferDays from './useLateEnrollmentBufferDays';
 
-const getContentListPrice = ({ courseRuns }) => {
+const getContentListPriceRange = ({ courseRuns }) => {
   const flatContentPrice = courseRuns.flatMap(run => run.listPrice?.usd).filter(x => !!x);
   // Find the max and min prices
   if (!flatContentPrice.length) {
-    return null;
+    return [];
   }
   const maxPrice = Math.max(...flatContentPrice);
   const minPrice = Math.min(...flatContentPrice);
@@ -32,7 +32,7 @@ export function transformCourseRedemptionEligibility({
   const otherSubsidyAccessPolicy = canRedeemData.find(
     r => r.redeemableSubsidyAccessPolicy,
   )?.redeemableSubsidyAccessPolicy;
-  const listPrice = getContentListPrice({ courseRuns: canRedeemData });
+  const listPrice = getContentListPriceRange({ courseRuns: canRedeemData });
   const hasSuccessfulRedemption = courseRunKey
     ? !!canRedeemData.find(r => r.contentKey === courseRunKey)?.hasSuccessfulRedemption
     : canRedeemData.some(r => r.hasSuccessfulRedemption);

src/components/course/CourseSidebarPrice.jsx

@@ -115,7 +115,7 @@ const CourseSidebarPrice = () => {
   const discountedPriceDisplay = `${getContentPriceDisplay(coursePrice.discountedList)} ${currency}`;
   return (
     <>
-      <div className={classNames({ 'mb-2': coursePrice.discountedList > 0 || showOrigPrice })}>
+      <div className={classNames({ 'mb-2': sumOfArray(coursePrice.discountedList) > 0 || showOrigPrice })}>
         {/* discountedList > 0 means partial discount */}
         {showOrigPrice && <>{crossedOutOriginalPrice}{' '}</>}
         {sumOfArray(coursePrice.discountedList) > 0 && (

src/components/course/data/hooks.jsx

@@ -173,8 +173,8 @@ export function useCoursePacingType(courseRun) {
 
 /**
  * @typedef {Object} CoursePrice
- * @property {number} listRange The list price.
- * @property {number} discountedList The discountedList price.
+ * @property {number[]} listRange The list price.
+ * @property {number[]} discountedListRange The discountedListRange price.
  */
 
 /**

src/components/course/data/tests/hooks.test.jsx

@@ -1676,6 +1676,8 @@ describe('useCourseListPrice', () => {
   beforeEach(() => {
     jest.clearAllMocks();
     useCourseRedemptionEligibility.mockReturnValue({ data: { listPrice: mockListPrice } });
+    // NOTE: `useCourseMetadata`'s mocked return value assumes the returned value
+    // from the `select` function passed to the hook.
     useCourseMetadata.mockReturnValue({ data: mockListPrice || getCoursePrice(baseCourseMetadataValue) });
   });
   it('should return the list price if one exist', () => {

src/components/course/data/utils.jsx

@@ -153,16 +153,14 @@ export function getProgramIcon(type) {
   }
 }
 
-export const numberWithPrecision = (number, precision = 2) => number.toFixed(precision);
-
 /**
  * Displays content price with precision as a range or singular price
  * @param priceRange
  * @returns {*|string}
  */
 export const getContentPriceDisplay = (priceRange) => {
   if (!priceRange?.length) {
-    return numberWithPrecision(ZERO_PRICE);
+    return formatPrice(ZERO_PRICE);
   }
   const minPrice = Math.min(...priceRange);
   const maxPrice = Math.max(...priceRange);