fix: remove Optimizely and surrounding components #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 96.23% 95.70% -0.53%
==========================================
Files 184 166 -18
Lines 1751 1491 -260
Branches 307 267 -40
==========================================
- Hits 1685 1427 -258
+ Misses 62 60 -2
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes a few tasks that help to clean up some of the code around initializing Optimizely. This code is left over from an old experiment that should now be done using the frontend-plugin-framework, instead of embedding code directly in the MFE.
What's covered in this PR
@optmizely/react-sdkdependency and references to SDK keys in.envfilesProductRecommendationsdirectory — the main component from the old experimentExperimentProvidercomponentoptimizelyScriptthat is injected into the<Head>WidgetFooter— used to render theProductRecommendationscomponent if the user was in the assigned experiment variantLoadedSidebarandNoCoursesSidebarwidgets into a singleWidgetSidebarcomponent — there was some code duplication here that seemed unnecessary