Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review on package dependencies #262

Closed
cintnguyen opened this issue Dec 21, 2023 · 4 comments
Closed

Review on package dependencies #262

cintnguyen opened this issue Dec 21, 2023 · 4 comments
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.

Comments

@cintnguyen
Copy link
Contributor

When referencing requirements for an MFE here , 13 is to only have hard dependencies on libraries that are either in the open edX organization or a commonly used third-party (generic NPM package) . During discovery found that:

  • "@optimizely/react-sdk" requires API keys making it not readily accessible to the community, referenced here. Is this something we can remove and replace? On npm, it states that it is an "A/B testing and feature management tool for product development teams that enables you to experiment at every step"
  • "react-zendesk" issues outlined in ZendeskFab #225 , wanted to bring attention to it. Not sure if we have something internal to replace
  • "@wojtekmaj/enzyme-adapter-react-17" is the unofficial adapter for react 17 from enzyme. Currently an inactive project. Can this be removed?
@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 12, 2024
@justinhynes
Copy link
Contributor

Thanks for bring attention to this. I have opened up an internal 2U ticket for Aperture to take a look at this and determine a path forward. It will be tracked as ticket APER-3568.

@MaxFrank13
Copy link
Member

MaxFrank13 commented Aug 6, 2024 •
edited
Loading

Optimizely removal has been merged: #386

@MaxFrank13
Copy link
Member

Enzyme adapter removal: #276

@MaxFrank13
Copy link
Member

Zendesk replacement/removal will be handled by the private ticket linked in #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer.
Projects
Aperture-Maintained
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@deborahgu @justinhynes @MaxFrank13 @cintnguyen