Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure highlights routes appear when learner credit is available #1043

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

adamstankiewicz
Copy link
Member

@adamstankiewicz adamstankiewicz commented Sep 28, 2023

Description

https://2u-internal.atlassian.net/browse/ENT-7759

The direct children of Switch must be Route. Previously, the LearnerCreditManagementRoutes component was rendered as the direct child instead of a Route, causing all Route definitions after LearnerCreditManagementRoutes to not work, which happened to only be ContentHighlights / NotFoundPage.

Before

image

After

image

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1d57072) 82.91% compared to head (ac6e827) 82.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1043      +/-   ##
==========================================
- Coverage   82.91%   82.90%   -0.02%     
==========================================
  Files         415      415              
  Lines        8933     8933              
  Branches     1832     1832              
==========================================
- Hits         7407     7406       -1     
- Misses       1484     1485       +1     
  Partials       42       42              
Files Coverage Δ
...c/components/EnterpriseApp/EnterpriseAppRoutes.jsx 65.00% <100.00%> (ø)
src/components/learner-credit-management/index.jsx 66.66% <100.00%> (-33.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamstankiewicz Thanks for pointing out and resolving this issue. LGTM 👍

@adamstankiewicz adamstankiewicz merged commit 9cc4dad into master Sep 28, 2023
5 of 6 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/investigate-blank-highlights-screen branch September 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants