fix: ensure highlights routes appear when learner credit is available (…

…#1043)

src/components/EnterpriseApp/EnterpriseAppRoutes.jsx

@@ -98,8 +98,9 @@ const EnterpriseAppRoutes = ({
       />
 
       {canManageLearnerCredit && (
-        <LearnerCreditManagementRoutes
-          baseUrl={baseUrl}
+        <Route
+          path={`${baseUrl}/admin/${ROUTE_NAMES.learnerCredit}`}
+          component={LearnerCreditManagementRoutes}
         />
       )}
 
@@ -110,7 +111,7 @@ const EnterpriseAppRoutes = ({
         />
       )}
 
-      <Route path="" component={NotFoundPage} />
+      <Route path="*" component={NotFoundPage} />
     </Switch>
   );
 };

src/components/learner-credit-management/index.jsx

@@ -1,28 +1,29 @@
 import React from 'react';
 import { Route } from 'react-router-dom';
 import PropTypes from 'prop-types';
-import { ROUTE_NAMES } from '../EnterpriseApp/data/constants';
 import MultipleBudgetsPage from './MultipleBudgetsPage';
 import BudgetDetailPage from './BudgetDetailPage';
 
-const LearnerCreditManagementRoutes = ({ baseUrl }) => (
+const LearnerCreditManagementRoutes = ({ match }) => (
   <>
     <Route
       exact
-      path={`${baseUrl}/admin/${ROUTE_NAMES.learnerCredit}`}
+      path={match.path}
       component={MultipleBudgetsPage}
     />
 
     <Route
       exact
-      path={`${baseUrl}/admin/${ROUTE_NAMES.learnerCredit}/:budgetId`}
+      path={`${match.path}/:budgetId`}
       component={BudgetDetailPage}
     />
   </>
 );
 
 LearnerCreditManagementRoutes.propTypes = {
-  baseUrl: PropTypes.string.isRequired,
+  match: PropTypes.shape({
+    path: PropTypes.string.isRequired,
+  }).isRequired,
 };
 
 export default LearnerCreditManagementRoutes;