Optionally add max and actual score for assignments to get_student_grade_summary_data output. #10395

ShawnMilo · 2015-10-28T14:43:13Z

Background Currently, only a grade between 0 and 1 is sent to the remote gradebook. The remote gradebook should receive both the raw grade (the float between 0 and 1) and the maximum score per assignment. This change is in response to issue #95 on mitocw/edx-platform. mitocw#95

This patch allows this additional data to be optionally added to the bundle passed to the code which writes the CSV file sent to the remote gradebook. After this patch is merged, additional work will have to be done to consume this new data during the CSV creation.

The remote gradebook feature has been in edX for almost three years. We believe that MIT is its only consumer.

Studio Updates None.

LMS Updates From issue #95:
...Course staff want to use edX to weight and scale grades, as presented by the LMS Progress tab.

In a nutshell, we intend to identify a source of the grade data, use that source to modify get_student_grade_summary_data() in legacy.py which is called by return_csv() in the same file.

Testing This feature can be run from the Legacy Dashboard for courses that are configured to use the remote gradebook feature. (The remote gradebook configuration is described here edx-platform/docs/en_us/internal/remote_gradebook.md.)

1 - The Gradebook Name is set as an advanced setting in Studio.
2 - The Export grades for assignment to remote gradebook executes the remote
gradebook feature.
3 - For testing, exporting the CSV file exercises the same code as we are
changing. It is an easy way to check the results.

Cover letter by @pwilkins

openedx-webhooks · 2015-10-28T14:43:19Z

Thanks for the pull request, @ShawnMilo! I've created OSPR-915 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
We can't start reviewing your pull request until you've added yourself to the AUTHORS file . Please see the CONTRIBUTING file for more information.

sarina · 2015-10-28T15:14:38Z

Hi @ShawnMilo Can you please add a description to your PR including what you're doing and why it is needed, and why you think it should be contributed upstream? See http://edx-developer-guide.readthedocs.org/en/latest/process/cover-letter.html for guidance.

pdpinch · 2015-10-30T13:03:37Z

@ShawnMilo this needs a rebase.

Also, the description could be more generic. Perhaps:

Currently, only a float between 0 and 1 is sent to the remote gradebook. The remote gradebook would like to have access to both the raw grade and the maximum score per assignment.

milocast · 2015-11-03T15:13:12Z

Hi @sarina. The tests have passed and we've updated the description. Please let me know if this needs anything else to be reviewed.

sarina · 2015-11-03T15:19:23Z

Has your team at MIT done a first round of review?

On Tue, Nov 3, 2015 at 10:13 AM, milocast notifications@github.com wrote:

Hi @sarina https://github.com/sarina. The tests have passed and we've
updated the description. Please let me know if this needs anything else to
be reviewed.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/10395#issuecomment-153384489.

pwilkins · 2015-11-04T20:49:14Z

LGTM @sarina @pdpinch

pdpinch · 2015-11-04T21:26:41Z

This has a thumbs up from me as well -- and not only because it doesn't have any user-facing effects.

@sarina let me know what additional review this needs.

sarina · 2015-11-04T22:09:34Z

lms/djangoapps/instructor/tests/test_legacy_raw_download_csv.py

@@ -69,7 +69,7 @@ def test_download_raw_grades_dump(self):

    def get_expected_grade_data(
            self, get_grades=True, get_raw_scores=False,
-            use_offline=False):
+            use_offline=False, get_score_max=False):


Please extend docstring to explain what this new option means

sarina · 2015-11-04T22:15:19Z

Would love more code documentation. Plus, please add yourself to AUTHORS.

This will put the actual score and actual max score in scope for the the return_csv function, so actual scores can be dumped. The ultimate goal is to provide this data in the CSV dump that is passed to Stellar via pylmod. This is PR openedx#10395 on edX, and issue 95 on mitocw's edx fork. https://github.com/edx/edx-platform/pull/10395 #95

sarina · 2015-11-09T17:03:46Z

@ShawnMilo FYI, reviewers don't get notified about new commits. So you need to write a comment on teh PR asking your reviewers to take another look.

sarina · 2015-11-09T17:05:43Z

👍

I will merge this, but ask that your team does validation when this goes to staging (est week after Thanksgiving).

Optionally add max and actual score for assignments to get_student_grade_summary_data output.

pdpinch · 2015-11-12T21:58:36Z

Thanks @sarina! @pwilkins and/or I will do the validation when the time comes.

This will put the actual score and actual max score in scope for the the return_csv function, so actual scores can be dumped. The ultimate goal is to provide this data in the CSV dump that is passed to Stellar via pylmod. This is PR #10395 on edX, and issue 95 on mitocw's edx fork. https://github.com/edx/edx-platform/pull/10395 mitocw#95

This will put the actual score and actual max score in scope for the the return_csv function, so actual scores can be dumped. The ultimate goal is to provide this data in the CSV dump that is passed to Stellar via pylmod. This is PR openedx#10395 on edX, and issue 95 on mitocw's edx fork. https://github.com/edx/edx-platform/pull/10395 #95

openedx-webhooks added open-source-contribution PR author is not from Axim or 2U needs triage labels Oct 28, 2015

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Oct 28, 2015

ShawnMilo force-pushed the feature/skm/add_max_score#95 branch from 2e276ee to 8659aa7 Compare October 29, 2015 18:03

ShawnMilo force-pushed the feature/skm/add_max_score#95 branch from 8659aa7 to 4ac05c3 Compare October 30, 2015 17:46

milocast mentioned this pull request Nov 3, 2015

Remote gradebook export should use weighted grades instead of normalized grades mitocw/edx-platform#95

Closed

1 task

sarina reviewed Nov 4, 2015
View reviewed changes

ShawnMilo force-pushed the feature/skm/add_max_score#95 branch from 4ac05c3 to 5d88300 Compare November 6, 2015 17:51

sarina added a commit that referenced this pull request Nov 9, 2015

Merge pull request #10395 from mitocw/feature/skm/add_max_score#95

2ae8ee2

Optionally add max and actual score for assignments to get_student_grade_summary_data output.

sarina merged commit 2ae8ee2 into openedx:master Nov 9, 2015

pdpinch deleted the feature/skm/add_max_score#95 branch November 12, 2015 21:58

pwilkins mentioned this pull request Nov 18, 2015

WIP: Improve usefulness of remote gradebook data mitocw/edx-platform#144

Open

pwilkins mentioned this pull request Nov 26, 2015

Allow course staff to submit raw score to remote gradebook mitocw/edx-platform#147

Open

pwilkins mentioned this pull request Dec 8, 2015

Send raw score and max points to remote gradebook #10890

Closed

pdpinch mentioned this pull request Feb 10, 2016

Added normalize column to export grade book to remote gradebook mitocw/edx-platform#201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optionally add max and actual score for assignments to get_student_grade_summary_data output. #10395

Optionally add max and actual score for assignments to get_student_grade_summary_data output. #10395

ShawnMilo commented Oct 28, 2015

openedx-webhooks commented Oct 28, 2015

sarina commented Oct 28, 2015

pdpinch commented Oct 30, 2015

milocast commented Nov 3, 2015

sarina commented Nov 3, 2015

pwilkins commented Nov 4, 2015

pdpinch commented Nov 4, 2015

sarina Nov 4, 2015

sarina commented Nov 4, 2015

sarina commented Nov 9, 2015

sarina commented Nov 9, 2015

pdpinch commented Nov 12, 2015

Optionally add max and actual score for assignments to get_student_grade_summary_data output. #10395

Optionally add max and actual score for assignments to get_student_grade_summary_data output. #10395

Conversation

ShawnMilo commented Oct 28, 2015

openedx-webhooks commented Oct 28, 2015

sarina commented Oct 28, 2015

pdpinch commented Oct 30, 2015

milocast commented Nov 3, 2015

sarina commented Nov 3, 2015

pwilkins commented Nov 4, 2015

pdpinch commented Nov 4, 2015

sarina Nov 4, 2015

Choose a reason for hiding this comment

sarina commented Nov 4, 2015

sarina commented Nov 9, 2015

sarina commented Nov 9, 2015

pdpinch commented Nov 12, 2015