Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send raw score and max points to remote gradebook #10890

Closed
wants to merge 1 commit into from
Closed

Send raw score and max points to remote gradebook #10890

wants to merge 1 commit into from

Conversation

pwilkins
Copy link
Contributor

@pwilkins pwilkins commented Dec 8, 2015

Background

edX supports sending grade data to a remote gradebook. Currently it sends students' calculated grades for a single assignment. This feature integrates edX with an institution's enterprise grading system. Improving the quality of this integration means reducing the manual effort to incorporate edX grades into a remote gradebook grade calculation.
Background

Currently edX's remote gradebook sends this CSV data to MIT's enterprise gradebook[1].

+-----------------+----------------+
| External email  | Ex 01          |
+-----------------+----------------+
| johndoe@mit.edu | 0.0            |
+-----------------+----------------+
| janedoe@mit.edu | 0.272727272727 |
+-----------------+----------------+

Note that the grade for assignment Ex 01 is a floating point number between 0 and 1. While this grade is meaningful in the context of edX, it is less useful in a remote grading system. The problem arises because edX is not the only source of assessment in residential course grading. There are usually other gradable events such as written assignments, lab work, and final exams. In practice, grade calculation can't be divided among multiple systems.

In the data example above, edX sends a calculated grade rather than a "raw" grade. The raw grade would be more useful because course graders must manually convert the edX grade to a raw score in the remote gradebook.

edX has already merged a PR (edx#10395) that makes edX's "raw grade" available to the remote gradebook code. edX's "raw grade" is a tuple containing the number of correct answers and the total number of questions.

Proposal

Send both the raw score and the max points to the remote gradebook by adding a column to the CSV data. This is a simple change that takes the raw grade tuple and passes it to the remote gradebook.

+-----------------+----------------+------------+
| External email  | Ex 01          | max points |
+-----------------+----------------+------------+
| johndoe@mit.edu | 0.0            | 5          |
+-----------------+----------------+------------+
| janedoe@mit.edu | 0.272727272727 | 5          |
+-----------------+----------------+------------+

This provides better integration with the remote gradebook. In addition to sending the raw score, it sends maximum points for the assignment relieving course staff from performing these steps manually.

@pdpinch

@openedx-webhooks
Copy link

Thanks for the pull request, @pwilkins! I've created OSPR-1009 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U needs triage labels Dec 8, 2015
@nedbat
Copy link
Contributor

nedbat commented Dec 8, 2015

@pwilkins is this used on edx.org? Or only on the MIT instance? @sarina is also interested...

@pwilkins
Copy link
Contributor Author

pwilkins commented Dec 8, 2015

We don't think anyone uses it but MIT.

@sarina
Copy link
Contributor

sarina commented Dec 8, 2015

Hi Peter,

Do you enable this feature on edx.org, or only on MIT's private instance?

On Tue, Dec 8, 2015 at 4:15 PM, Peter Wilkins notifications@github.com
wrote:

We don't think anyone uses it but MIT.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/10890#issuecomment-163019856.

@pwilkins
Copy link
Contributor Author

pwilkins commented Dec 8, 2015

We enable it only on MIT’s instance.

@pwilkins pwilkins force-pushed the feature/pw/remote-gradebook-max-score branch from 7a8b3d0 to a97014f Compare December 8, 2015 21:40
@sarina
Copy link
Contributor

sarina commented Dec 8, 2015

OK, thanks. I will be reaching out shortly with some detail, but this will
be the last PR we accept to the legacy dashboard. Once Dogwood is cut we
will be removing it, and any lingering features will need to be ported to
the regular instructor dash.

On Tue, Dec 8, 2015 at 4:32 PM, Peter Wilkins notifications@github.com
wrote:

We enable it only on MIT’s instance.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/10890#issuecomment-163023802.

pdpinch
pdpinch reviewed Dec 10, 2015
View reviewed changes
lms/djangoapps/instructor/views/legacy.py
course,
get_grades=True,
use_offline=use_offline,
get_raw_scores=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. We don't want to get_raw_scores for the remote gradebook. We want assignments.

@pwilkins pwilkins force-pushed the feature/pw/remote-gradebook-max-score branch from a97014f to f7832a6 Compare December 11, 2015 01:52
@pdpinch
Copy link
Contributor

pdpinch commented Dec 11, 2015

Thanks @pwilkins -- can you rebase?

@pwilkins pwilkins force-pushed the feature/pw/remote-gradebook-max-score branch from f7832a6 to c44ffa7 Compare December 11, 2015 02:31
@pwilkins
Send raw score and max points to remote gradebook.
d924c80 
Raw scores and max points are more useful to instructors in the
remote gradebook than the calculated scores sent now.

Fixes #36

@pdpinch
@pwilkins pwilkins force-pushed the feature/pw/remote-gradebook-max-score branch from c44ffa7 to d924c80 Compare December 11, 2015 19:33
pwilkins
pwilkins reviewed Dec 14, 2015
View reviewed changes
lms/djangoapps/instructor/tests/test_legacy_raw_download_csv.py
0, 0, 0, 0.0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
],
[
2, u'u2', u'username', u'view2@test.com', '', 0.3333333333333333, 0, 0, 0,
2, u'u2', u'username', u'view2@test.com', '', (1.0, 3.0), 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0.03333333333333333, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was puzzled why I had to replace the first non-zero grade for this user but not the second. I found that the second non-zero score is the average grade for the category (HW Avg) so the data for points earned and max points possible is not easily available. @pdpinch

@sarina
Copy link
Contributor

sarina commented Dec 14, 2015

@pwilkins @pdpinch Was the intention here to get this into the Dogwood release? We have based that off the most recent RC, and we are planning to remove entirely the Legacy Dashboard soon (ie in the next day or two)

@sarina
Copy link
Contributor

sarina commented Dec 14, 2015

Actually I'm probably going to be merging the PR to remove the legacy dash today. If the goal is to get this into Dogwood, you should close this PR and make a PR against the Dogwood RC when it is available.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed community manager review labels Dec 14, 2015
@sarina sarina closed this Dec 14, 2015
@sarina
Copy link
Contributor

sarina commented Dec 14, 2015

Closing due to https://github.com/edx/edx-platform/pull/10942's merge

This was referenced Jan 19, 2016
Closed
Open
@pwilkins pwilkins mentioned this pull request Jan 27, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pwilkins @openedx-webhooks @nedbat @sarina @pdpinch