Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unencrypted user credentials data #1966

Merged

Conversation

MueezKhan246
Copy link
Contributor

Description:
removed un encrypted user credentials data and testing feature flag.

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-5613

@MueezKhan246
Copy link
Contributor Author

@sameenfatima78
This PR is to be deployed after Replacing Encrypted Fields With Non Encrypted gets tested on prod.

integrated_channels/moodle/models.py Outdated Show resolved Hide resolved
integrated_channels/moodle/client.py Outdated Show resolved Hide resolved
@hamzawaleed01
Copy link
Member

LGTM! let's wait for a review from @zamanafzal and @sameenfatima78

Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once we have added the version upgrade files.

…to MueezKhan/Removing-Unencrypted-User-Credentials-Data
@MueezKhan246 MueezKhan246 force-pushed the MueezKhan/Removing-Unencrypted-User-Credentials-Data branch from 5fc07f0 to 4c7bc23 Compare January 15, 2024 10:02
…to MueezKhan/Removing-Unencrypted-User-Credentials-Data
@MueezKhan246 MueezKhan246 merged commit cc843d7 into master Jan 15, 2024
9 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Removing-Unencrypted-User-Credentials-Data branch January 15, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants