Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Encrypted Fields With Non Encrypted #1897

Merged

Conversation

MueezKhan246
Copy link
Contributor

Description:
Replacing non encrypted fields of moodle config model with encrypted ones.

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-5613

@MueezKhan246 MueezKhan246 force-pushed the MueezKhan/Replacing-Encrypted-Fields-With-Non-Encrypted branch from ba180c4 to aa4d2a1 Compare October 5, 2023 13:03
Copy link
Member

@hamzawaleed01 hamzawaleed01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

integrated_channels/moodle/admin/__init__.py Outdated Show resolved Hide resolved
integrated_channels/moodle/client.py Outdated Show resolved Hide resolved
integrated_channels/moodle/models.py Outdated Show resolved Hide resolved
integrated_channels/moodle/models.py Outdated Show resolved Hide resolved
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, LGTM! :shipit:

integrated_channels/api/v1/moodle/serializers.py Outdated Show resolved Hide resolved
@MueezKhan246 MueezKhan246 merged commit bbe649e into master Dec 20, 2023
7 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Replacing-Encrypted-Fields-With-Non-Encrypted branch December 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants