Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nvmf): selection different CRD for replicas and certain nexus error #1524

Merged
merged 1 commit into from
Oct 28, 2023
Merged

feat(nvmf): selection different CRD for replicas and certain nexus error #1524

merged 1 commit into from
Oct 28, 2023

Conversation

dsavitskiy
Copy link
Contributor

NVMF subsystem will select different preconfigured CRDs for certain cases:
3 is selected for replica targets
2 is selected for ENOSPC and reservation errors on nexus targets
1 is select for all other error on nexus target

@auto-assign auto-assign bot requested a review from chriswldenyer October 13, 2023 09:17
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 13, 2023
Try #1524:
c804e45
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Build failed:

@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch 2 times, most recently from 248a1d3 to 99a14b8 Compare October 13, 2023 16:32
@dsavitskiy
Copy link
Contributor Author

bors try

1 similar comment
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 13, 2023
Try #1524:
daebe4c
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Build failed:

@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 13, 2023
Try #1524:
a672cb9
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Build failed:

@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from 99a14b8 to ec7f3fc Compare October 13, 2023 19:26
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 13, 2023
Try #1524:
e405ec4
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Build failed:

@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from ec7f3fc to cfa5cdf Compare October 16, 2023 11:39
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Try #1524:
3e1c90d
@bors
Copy link
Contributor

bors bot commented Oct 16, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from cfa5cdf to 09630ff Compare October 19, 2023 14:56
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 19, 2023
Try #1524:
4c3b964
@bors
Copy link
Contributor

bors bot commented Oct 19, 2023

try

Build failed:

@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from 09630ff to e34d4f9 Compare October 19, 2023 15:52
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 19, 2023
Try #1524:
9a3c225
@bors
Copy link
Contributor

bors bot commented Oct 19, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

tiagolobocastro
tiagolobocastro reviewed Oct 19, 2023
View reviewed changes
io-engine/src/core/env.rs Outdated Show resolved Hide resolved
io-engine/src/core/env.rs Show resolved Hide resolved
io-engine/src/subsys/nvmf/subsystem.rs Show resolved Hide resolved
io-engine/src/core/env.rs Outdated Show resolved Hide resolved
dsharma-dc
dsharma-dc reviewed Oct 23, 2023
View reviewed changes
io-engine/src/bdev/nexus/nexus_io.rs Show resolved Hide resolved
io-engine/src/core/env.rs Outdated Show resolved Hide resolved
@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from e34d4f9 to 68ee03b Compare October 25, 2023 13:34
@dsavitskiy
Copy link
Contributor Author

bors try

bors bot pushed a commit that referenced this pull request Oct 25, 2023
Try #1524:
8fa1752
tiagolobocastro
tiagolobocastro approved these changes Oct 25, 2023
View reviewed changes
io-engine/src/core/env.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@dsavitskiy dsavitskiy closed this Oct 28, 2023
@dsavitskiy dsavitskiy force-pushed the feature/advanced-crdt branch from 68ee03b to d138a30 Compare October 28, 2023 03:37
@dsavitskiy
feat(nvmf): selecting different CRD for replicas and certain nexus er…
f9e5a81 
…rors

NVMF subsystem will select different preconfigured CRDs for certain cases:
openebs#1 is selected for all errors on nexus target except ENOSPC and
  reservation conflict
openebs#2 is selected for ENOSPC and reservation conflict errors on nexus targets
openebs#3 is selected for replica targets

Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
@dsavitskiy dsavitskiy reopened this Oct 28, 2023
@dsavitskiy
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 28, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit a7b0f05 into openebs:develop Oct 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharma-dc dsharma-dc dsharma-dc approved these changes

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@hrudaya21 hrudaya21 Awaiting requested review from hrudaya21

@chriswldenyer chriswldenyer Awaiting requested review from chriswldenyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsavitskiy @tiagolobocastro @dsharma-dc