Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting of created replicas over nvmf #3

Closed
wants to merge 0 commits into from
Closed

Conversation

jkryl
Copy link
Contributor

@jkryl jkryl commented Sep 19, 2019

The management api was enhanced with a new "share" parameter to be able
to set share protocol for replica. Currently can be "none" or "nvmf".
In future we plan to add "iscsi" as an alternative to nvmf because
spdk's nvme initiator code is missing error recovery algorithm.

mayastor shutdown code had to be enhanced to support asynchronous code
execution before the executor is destroyed and spdk_stop() called.
Otherwise there is no chance to properly destroy nvmf subsystems before
the mayastor terminates which triggers an assertion.

@jkryl jkryl requested a review from gila September 19, 2019 19:17
@jkryl jkryl self-assigned this Sep 19, 2019
@gila gila added the Enhancement New feature or request label Sep 20, 2019
@jkryl jkryl closed this Sep 20, 2019
@jkryl jkryl deleted the nvmf_tgt branch September 20, 2019 07:16
tjoshum pushed a commit that referenced this pull request Mar 10, 2020
Record the share protocol used to publish the nexus.

This so that the nexus can use the appropriate action at unpublish.
dsavitskiy added a commit to dsavitskiy/mayastor that referenced this pull request Nov 8, 2021
dsavitskiy added a commit that referenced this pull request Nov 3, 2022
dsavitskiy added a commit that referenced this pull request Nov 16, 2022
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
dsavitskiy added a commit that referenced this pull request Nov 17, 2022
Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
dsavitskiy added a commit to dsavitskiy/mayastor that referenced this pull request Oct 28, 2023
…rors

NVMF subsystem will select different preconfigured CRDs for certain cases:
openebs#1 is selected for all errors on nexus target except ENOSPC and
  reservation conflict
openebs#2 is selected for ENOSPC and reservation conflict errors on nexus targets
openebs#3 is selected for replica targets

Signed-off-by: Dmitry Savitskiy <dmitry.savitskiy@datacore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants