-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Cypress 12 #908
Merged
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
52a982b
New Cypress version + some improvements
garcanam c388589
Jenkins file changes: add videos + combine reports
garcanam 1f3aa4f
Remove Dashboard + update readme
garcanam 18226a3
Remove unneeded config
garcanam 513fab0
Update e2e-cypress/files/cypress.config.ts
garcanam c0a639b
Update cypress.config.ts
garcanam 0ebe54d
Update Jenkinsfile.template
garcanam a80810f
Update e2e.ts
garcanam 9fe1d59
Update installation.spec.cy.ts
garcanam a26ac6d
improvements
roicarrera 00ea41d
Update e2e-cypress/files/support/e2e.ts
roicarrera f1ca562
added changelog.md
roicarrera be997d3
Merge branch 'master' of https://github.com/garcanam/ods-quickstarters
roicarrera 8e13ec9
changed junit reporter
roicarrera 1863429
moved changelog
roicarrera 470568b
added changes to changelog
roicarrera e7a51e4
fixed typos
roicarrera 828ea1f
Merge branch 'master' into master
garcanam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
### Added | ||
- New login example with cy.origin() ([#899](https://github.com/opendevstack/ods-quickstarters/issues/899)) | ||
- Upload videos ([#899](https://github.com/opendevstack/ods-quickstarters/issues/899)) | ||
|
||
### Changes | ||
- Upgraded to Cypress 12 ([#899](https://github.com/opendevstack/ods-quickstarters/issues/899)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { defineConfig } from 'cypress' | ||
import setupNodeEvents from './plugins/index.js' | ||
export default defineConfig({ | ||
reporter: 'junit', | ||
reporterOptions: { | ||
mochaFile: 'build/test-results/acceptance-junit-[hash].xml', | ||
toConsole: true, | ||
}, | ||
e2e: { | ||
baseUrl: 'https://www.w3schools.com', | ||
fixturesFolder: "fixtures", | ||
specPattern: 'tests/acceptance/*.cy.ts', | ||
supportFile: "support/e2e.ts", | ||
viewportWidth: 1376, | ||
viewportHeight: 660, | ||
experimentalModifyObstructiveThirdPartyCode:true, | ||
video: true, | ||
setupNodeEvents(on, config) { | ||
return require('./plugins/index.js')(on, config) | ||
}, | ||
}, | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { defineConfig } from 'cypress' | ||
import setupNodeEvents from './plugins/index.js' | ||
export default defineConfig({ | ||
//projectId: '[Define your project id for Cypress cloud]', | ||
reporter: 'junit', | ||
reporterOptions: { | ||
mochaFile: 'build/test-results/installation-junit-[hash].xml', | ||
toConsole: true, | ||
}, | ||
e2e: { | ||
baseUrl: 'https://www.w3schools.com', | ||
fixturesFolder: "fixtures", | ||
specPattern: 'tests/installation/*.cy.ts', | ||
supportFile: "support/e2e.ts", | ||
viewportWidth: 1376, | ||
viewportHeight: 660, | ||
experimentalModifyObstructiveThirdPartyCode:true, | ||
video: true, | ||
setupNodeEvents(on, config) { | ||
return require('./plugins/index.js')(on, config) | ||
}, | ||
}, | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import { defineConfig } from 'cypress' | ||
import setupNodeEvents from './plugins/index.js' | ||
export default defineConfig({ | ||
//projectId: '[Define your project id for Cypress cloud]', | ||
reporter: 'junit', | ||
reporterOptions: { | ||
mochaFile: 'build/test-results/integration-junit-[hash].xml', | ||
toConsole: true, | ||
}, | ||
e2e: { | ||
baseUrl: 'https://www.w3schools.com', | ||
fixturesFolder: "fixtures", | ||
specPattern: 'tests/integration/*.cy.ts', | ||
supportFile: "support/e2e.ts", | ||
viewportWidth: 1376, | ||
viewportHeight: 660, | ||
experimentalModifyObstructiveThirdPartyCode:true, | ||
video: true, | ||
setupNodeEvents(on, config) { | ||
return require('./plugins/index.js')(on, config) | ||
}, | ||
}, | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { defineConfig } from 'cypress' | ||
import setupNodeEvents from './plugins/index.js' | ||
export default defineConfig({ | ||
reporter: 'junit', | ||
reporterOptions: { | ||
mochaFile: 'build/test-results/tests-[hash].xml', | ||
toConsole: true, | ||
}, | ||
e2e: { | ||
baseUrl: 'https://www.w3schools.com', | ||
fixturesFolder: "fixtures", | ||
specPattern: 'tests/**/*.cy.ts', | ||
supportFile: "support/e2e.ts", | ||
viewportWidth: 1376, | ||
viewportHeight: 660, | ||
experimentalModifyObstructiveThirdPartyCode: true, | ||
video: true, | ||
setupNodeEvents(on, config) { | ||
return require('./plugins/index.js')(on, config) | ||
}, | ||
}, | ||
}) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
//For more details, you can follow this link: | ||
//https://docs.cypress.io/guides/end-to-end-testing/azure-active-directory-authentication#Microsoft-AAD-Application-Setup | ||
function loginViaAAD(username: string, password: string) { | ||
|
||
//Go to your application URL and trigger the login. | ||
cy.visit('') | ||
|
||
//If needed, navigate and click on the login button. | ||
//As an example: | ||
//cy.get('button#signIn').click() | ||
|
||
//Login to your AAD tenant. | ||
//ATENTION: The redirection can happen at the 'login.microsoftonline.com' and also it might redirect as well to 'login.live.com' | ||
cy.origin( | ||
'https://login.microsoftonline.com', | ||
{ | ||
args: { | ||
username, | ||
password, | ||
}, | ||
}, | ||
({ username, password }) => { | ||
cy.get('input[type="email"]').type(username, { | ||
log: false, | ||
}) | ||
cy.get('input[type="submit"]').click() | ||
cy.get('input[type="password"]').type(password, { | ||
log: false, | ||
}) | ||
cy.get('input[type="submit"]').click() | ||
} | ||
) | ||
|
||
//Depending on the user and how they are registered with Microsoft, the origin may go to live.com | ||
garcanam marked this conversation as resolved.
Show resolved
Hide resolved
|
||
//cy.origin( | ||
// 'login.live.com', | ||
// { | ||
// args: { | ||
// password, | ||
// }, | ||
// }, | ||
// ({ password }) => { | ||
// cy.get('input[type="password"]').type(password, { | ||
// log: false, | ||
// }) | ||
// cy.get('input[type="submit"]').click() | ||
// cy.get('#idBtn_Back').click() | ||
// } | ||
//) | ||
|
||
// Ensure Microsoft has redirected us back to the sample app with our logged in user. | ||
cy.url().should('equal', Cypress.config().baseUrl) | ||
} | ||
|
||
//See how to use it at: | ||
//tests/acceptance/acceptance.spec.cy.ts | ||
Cypress.Commands.add('loginToAAD', (username: string, password: string) => { | ||
const log = Cypress.log({ | ||
displayName: 'Azure Active Directory Login', | ||
message: [`🔐 Authenticating | ${username}`], | ||
autoEnd: false, | ||
}) | ||
log.snapshot('before') | ||
|
||
loginViaAAD(username, password) | ||
|
||
log.snapshot('after') | ||
log.end() | ||
}) |
This file was deleted.
Oops, something went wrong.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a changelog for the whole repository (https://github.com/opendevstack/ods-quickstarters/blob/master/CHANGELOG.md). AFAIK we don't have per-QS changelogs so far. I guess there should be an entry there instead of creating a separate changelog here. I'd keep it a one-line entry, e.g. something like