Upgrade to Cypress 12 #908
Conversation
|
Nodejs18 test is failing but it should have been fixed in #906..... |
|
Hi @garcanam , please fix the merge conflict (rebase master) it should also incorporate the fix for the NodeJS 18 build. |
e2e-cypress/Jenkinsfile.template
Outdated
| workingDir: '/tmp', | ||
| resourceRequestCpu: '1000m', | ||
| resourceLimitCpu: '5000m', | ||
| resourceRequestMemory: '4Gi', |
There was a problem hiding this comment.
resourceRequestMemory: '4Gi' seems a lot too me. Is it needed?
e2e-cypress/files/cypress.config.ts
Outdated
| viewportHeight: 660, | ||
| experimentalModifyObstructiveThirdPartyCode:true, | ||
| //https://github.com/cypress-io/cypress/issues/25806 | ||
| // experimentalSkipDomainInjection: ["*.apps.eu-dev.ocp.aws.boehringer.com"], |
There was a problem hiding this comment.
Are those comments needed? Or maybe they would need a little more explanation.
e2e-cypress/files/cypress.config.ts
Outdated
| supportFile: "support/e2e.ts", | ||
| viewportWidth: 1376, | ||
| viewportHeight: 660, | ||
| experimentalModifyObstructiveThirdPartyCode:true, |
There was a problem hiding this comment.
| experimentalModifyObstructiveThirdPartyCode:true, | |
| experimentalModifyObstructiveThirdPartyCode: true, |
There was a problem hiding this comment.
There are some formatting issues here and there, e.g. inconsistant usage of 'foo' vs. "foo". Have you thought about running some code formatter like prettier?
Co-authored-by: Christian Schweikert <43915417+cschweikert@users.noreply.github.com>
Co-authored-by: Christian Schweikert <43915417+cschweikert@users.noreply.github.com>
removed unneeded comment
e2e-cypress/changelog.md
Outdated
There was a problem hiding this comment.
There is already a changelog for the whole repository (https://github.com/opendevstack/ods-quickstarters/blob/master/CHANGELOG.md). AFAIK we don't have per-QS changelogs so far. I guess there should be an entry there instead of creating a separate changelog here. I'd keep it a one-line entry, e.g. something like
- Upgraded to Cypress 12, improve login support, add video support ([#899](https://github.com/opendevstack/ods-quickstarters/issues/899))
Description
Upgrade to Cypress 12. New login example with cy.origin() and upload videos.
Fixes
#899