Dockerfile.ubi: use cuda-base as base for vllm-openai target #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixed upstream in vllm-project#5091
fixes RHOAIENG-8043 Co-authored-by: Chih-Chieh-Yang <chih.chieh.yang@ibm.com> Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
dtrifiro
force-pushed
the
change-vllm-openai-base
branch
from
8ba81b4
to
712ffff
Compare
this adds the cuda runtime in order to fix missing libcudart.so.12 on vLLM libraries
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dtrifiro
force-pushed
the
main
branch
2 times, most recently
from
8a0593d
to
3c182aa
Compare
|
moved to #126 |
Merged
Xaenalt
pushed a commit
that referenced
this pull request
Sep 18, 2024
prarit
pushed a commit
to prarit/vllm
that referenced
this pull request
Oct 18, 2024
* fix __init__ files * make yapf happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the cuda runtime in order to fix missing libcudart.so.12 on vLLM libraries.