Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build for 0.5.4 #127

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented Aug 13, 2024

  • deps: bump vllm-tgis-adapter to 0.3.0 to include 0.5.4 fixes
  • deps: bump flashinfer to 0.1.2
  • Dockerfile.ubi: force using python-installed cuda runtime libraries
  • Dockerfile.ubi: downgrade build-stage CUDA to 12.1 for torch==2.4.0 compatibility
  • Dockerfile: use uv pip everywhere (it's faster)

Copy link

openshift-ci bot commented Aug 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtrifiro
Copy link
Author

This is an alternative approach to the fixes proposed in #126, which should keep the image size smaller because of the reuse of the cuda runtime libraries in the python venv

Dockerfile.ubi Outdated Show resolved Hide resolved
@dtrifiro
Copy link
Author

/test all

@dtrifiro
Copy link
Author

/test all

@dtrifiro dtrifiro marked this pull request as ready for review August 13, 2024 11:45
@dtrifiro
Copy link
Author

/retest

1 similar comment
@dtrifiro
Copy link
Author

/retest

@dtrifiro
Copy link
Author

The smoke test has failed due to some issue with the cluster, but the image itself is working:

quay.io/opendatahub/vllm:pr-127

@dtrifiro dtrifiro added the lgtm label Aug 14, 2024
@dtrifiro
Copy link
Author

/retest-required

@dtrifiro
Copy link
Author

/retest

1 similar comment
@dtrifiro
Copy link
Author

/retest

@dtrifiro dtrifiro enabled auto-merge (rebase) August 14, 2024 17:53
@prashantgupta24
Copy link

/retest

Copy link

openshift-ci bot commented Aug 15, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test ce9e5de link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dtrifiro dtrifiro disabled auto-merge August 19, 2024 09:22
@dtrifiro dtrifiro merged commit 9460cfb into opendatahub-io:main Aug 19, 2024
18 of 20 checks passed
@dtrifiro dtrifiro deleted the fix-build-for-0.5.4 branch August 19, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants