-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api version for internal apis to v1alpha1 #1416
Update api version for internal apis to v1alpha1 #1416
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lburgazzoli @zdtsw @ykaliuta Addressed comments from #1411 |
@@ -26,7 +26,7 @@ import ( | |||
|
|||
var ( | |||
// GroupVersion is group version used to register these objects | |||
GroupVersion = schema.GroupVersion{Group: "components.opendatahub.io", Version: "v1"} | |||
GroupVersion = schema.GroupVersion{Group: "platform.opendatahub.io", Version: "v1alpha1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if we want to have an additional level i.e components.platform.opendatahub.io
, services.platform.opendatahub.io
, and so on.
no strong opinion though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we might have different version on component and service later? v1alpha1 v1beta10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly for discovering:
to know what components are shipped as part of the platform:
kubectl api-resources --api-group components.platform.opendatahub.io
to know what services are shipped as part of the platform:
kubectl api-resources --api-group services.platform.opendatahub.io
etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we probably can have different versions. And yes I remember we wanted to have easy discovery, so having this 2 groups makes sense.
f3ef8ef
to
2fb10ae
Compare
/test opendatahub-operator-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature-operator-refactor #1416 +/- ##
============================================================
Coverage ? 26.84%
============================================================
Files ? 65
Lines ? 5160
Branches ? 0
============================================================
Hits ? 1385
Misses ? 3613
Partials ? 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
d4f72fa
into
opendatahub-io:feature-operator-refactor
Description
This PR introduces following changes:
v1alpha1
components
andservices
to*.platform.opendatahub.io
How Has This Been Tested?
Screenshot or short clip
Merge criteria