Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api version for internal apis to v1alpha1 #1416

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Dec 3, 2024

Description

This PR introduces following changes:

  • API versions updated to v1alpha1
  • Updated apigroup for components and services to *.platform.opendatahub.io

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vaishnavihire. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire
Copy link
Member Author

@lburgazzoli @zdtsw @ykaliuta Addressed comments from #1411

@@ -26,7 +26,7 @@ import (

var (
// GroupVersion is group version used to register these objects
GroupVersion = schema.GroupVersion{Group: "components.opendatahub.io", Version: "v1"}
GroupVersion = schema.GroupVersion{Group: "platform.opendatahub.io", Version: "v1alpha1"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder if we want to have an additional level i.e components.platform.opendatahub.io, services.platform.opendatahub.io, and so on.

no strong opinion though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we might have different version on component and service later? v1alpha1 v1beta10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly for discovering:

to know what components are shipped as part of the platform:

kubectl api-resources --api-group components.platform.opendatahub.io

to know what services are shipped as part of the platform:

kubectl api-resources --api-group services.platform.opendatahub.io

etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we probably can have different versions. And yes I remember we wanted to have easy discovery, so having this 2 groups makes sense.

@VaishnaviHire
Copy link
Member Author

/test opendatahub-operator-e2e

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature-operator-refactor@2aff8dc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atasciencecluster/datasciencecluster_controller.go 0.00% 14 Missing ⚠️
pkg/controller/reconciler/reconciler.go 0.00% 1 Missing ⚠️
pkg/controller/reconciler/reconciler_support.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1416   +/-   ##
============================================================
  Coverage                             ?   26.84%           
============================================================
  Files                                ?       65           
  Lines                                ?     5160           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1385           
  Misses                               ?     3613           
  Partials                             ?      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lburgazzoli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@zdtsw zdtsw merged commit d4f72fa into opendatahub-io:feature-operator-refactor Dec 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants