Update interface name

opendatahub-io · Dec 3, 2024 · f3ef8ef · f3ef8ef
1 parent 75d3e39
commit f3ef8ef
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/apis/common/types.go b/apis/common/types.go
@@ -73,7 +73,7 @@ type WithDevFlags interface {
 	GetDevFlags() *DevFlags
 }
 
-type BaseObject interface {
+type PlatformObject interface {
 	client.Object
 	WithStatus
 	WithDevFlags

diff --git a/pkg/controller/actions/render/kustomize/action_render_manifests.go b/pkg/controller/actions/render/kustomize/action_render_manifests.go
@@ -79,7 +79,7 @@ func (a *Action) run(ctx context.Context, rr *types.ReconciliationRequest) error
 	var err error
 	var cachingKey []byte
 
-	inst, ok := rr.Instance.(common.BaseObject)
+	inst, ok := rr.Instance.(common.PlatformObject)
 	if ok && inst.GetDevFlags() != nil {
 		// if dev flags are enabled, caching is disabled as dev flags are meant for
 		// development time only where caching is not relevant

diff --git a/pkg/controller/actions/render/template/action_render_templates.go b/pkg/controller/actions/render/template/action_render_templates.go
@@ -55,7 +55,7 @@ func (a *Action) run(ctx context.Context, rr *types.ReconciliationRequest) error
 	var err error
 	var cachingKey []byte
 
-	inst, ok := rr.Instance.(common.BaseObject)
+	inst, ok := rr.Instance.(common.PlatformObject)
 	if ok && inst.GetDevFlags() != nil {
 		// if dev flags are enabled, caching is disabled as dev flags are meant for
 		// development time only where caching is not relevant

diff --git a/pkg/controller/reconciler/reconciler.go b/pkg/controller/reconciler/reconciler.go
@@ -27,7 +27,7 @@ import (
 )
 
 // Reconciler provides generic reconciliation functionality for ODH objects.
-type Reconciler[T common.BaseObject] struct {
+type Reconciler[T common.PlatformObject] struct {
 	Client     *odhClient.Client
 	Scheme     *runtime.Scheme
 	Actions    []actions.Fn
@@ -43,7 +43,7 @@ type Reconciler[T common.BaseObject] struct {
 }
 
 // NewReconciler creates a new reconciler for the given type.
-func NewReconciler[T common.BaseObject](mgr manager.Manager, name string, object T) (*Reconciler[T], error) {
+func NewReconciler[T common.PlatformObject](mgr manager.Manager, name string, object T) (*Reconciler[T], error) {
 	oc, err := odhClient.NewFromManager(mgr)
 	if err != nil {
 		return nil, err

diff --git a/pkg/controller/reconciler/reconciler_actions_test.go b/pkg/controller/reconciler/reconciler_actions_test.go
@@ -25,7 +25,7 @@ import (
 func TestDynamicWatchAction_Run(t *testing.T) {
 	tests := []struct {
 		name       string
-		object     common.BaseObject
+		object     common.PlatformObject
 		preds      []DynamicPredicate
 		errMatcher gomegaTypes.GomegaMatcher
 		cntMatcher gomegaTypes.GomegaMatcher

diff --git a/pkg/controller/reconciler/reconciler_support.go b/pkg/controller/reconciler/reconciler_support.go
@@ -85,7 +85,7 @@ func Dynamic(predicates ...DynamicPredicate) WatchOpts {
 	}
 }
 
-type ReconcilerBuilder[T common.BaseObject] struct {
+type ReconcilerBuilder[T common.PlatformObject] struct {
 	mgr          ctrl.Manager
 	input        forInput
 	watches      []watchInput
@@ -96,7 +96,7 @@ type ReconcilerBuilder[T common.BaseObject] struct {
 	errors       error
 }
 
-func ReconcilerFor[T common.BaseObject](mgr ctrl.Manager, object T, opts ...builder.ForOption) *ReconcilerBuilder[T] {
+func ReconcilerFor[T common.PlatformObject](mgr ctrl.Manager, object T, opts ...builder.ForOption) *ReconcilerBuilder[T] {
 	crb := ReconcilerBuilder[T]{
 		mgr: mgr,
 	}