RHOAIENG-3761: adding monitoring config and metrics viewing section for multi model #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbyrne-redhat
suggested changes
Mar 4, 2024
| :_module-type: PROCEDURE | ||
|
|
||
| [id="configuring-monitoring-for-the-multi-model-serving-platform_{context}"] | ||
| = Configuring monitoring for the multi model serving platform |
There was a problem hiding this comment.
Ensure that we're hyphenating "multi-model" for all occurrences of "multi-model serving platform".
| The single model serving platform includes metrics for Caikit and TGIS. You can also configure monitoring for OpenShift Service Mesh. The service mesh metrics helps you to understand dependencies and traffic flow between components in the mesh. When you have configured monitoring, you can grant Prometheus access to scrape the available metrics. | ||
|
|
||
| ifdef::self-managed,cloud-service[] | ||
| The single model serving platform includes metrics for link:{rhoaidocshome}{default-format-url}/serving_models/serving-large-models_serving-large-models#about-the-single-model-serving-platform_serving-large-models[supported runtimes]. You can also configure monitoring for OpenShift Service Mesh. The service mesh metrics helps you to understand dependencies and traffic flow between components in the mesh. When you have configured monitoring, you can grant Prometheus access to scrape the available metrics. |
There was a problem hiding this comment.
We need to do an overall sweep of the docs to replace "single model serving platform" with "single-model serving platform" because it was renamed to add the hyphen in 2.7. But can you update this occurrence?
| The single model serving platform includes metrics for link:{rhoaidocshome}{default-format-url}/serving_models/serving-large-models_serving-large-models#about-the-single-model-serving-platform_serving-large-models[supported runtimes]. You can also configure monitoring for OpenShift Service Mesh. The service mesh metrics helps you to understand dependencies and traffic flow between components in the mesh. When you have configured monitoring, you can grant Prometheus access to scrape the available metrics. | ||
| endif::[] | ||
| ifdef::upstream[] | ||
| The single model serving platform includes metrics for link:{odhdocshome}/serving_models/serving-large-models_serving-large-models#about-the-single-model-serving-platform_serving-large-models[supported runtimes]. You can also configure monitoring for OpenShift Service Mesh. The service mesh metrics helps you to understand dependencies and traffic flow between components in the mesh. When you have configured monitoring, you can grant Prometheus access to scrape the available metrics. |
There was a problem hiding this comment.
Same as previous comment.
jbyrne-redhat
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-3761
Description
RHOAIENG-3761: Add procedure for configuring monitoring and viewing metrics on multi-model serving platform
How Has This Been Tested?
Local upstream and downstream builds
#Previews
Serving models self-managed preview.pdf