Disable virtual host functionality of kserve

[vaibhavjainwiz]

Description

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[israel-hdez]

Changes to kserve-built can be overriden by local patches.

We have one here for this ConfigMap: https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/base/inferenceservice-config-patch.yaml.

You should apply the change in that patch rather than in kserve-built. Unfortunately, that patch is outdated. You will need to wait for #908 to go in and apply your changes on top of that.

[vaibhavjainwiz]

Changes to kserve-built can be overriden by local patches.

We have one here for this ConfigMap: https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/base/inferenceservice-config-patch.yaml.

You should apply the change in that patch rather than in kserve-built. Unfortunately, that patch is outdated. You will need to wait for #908 to go in and apply your changes on top of that.

@israel-hdez I had done the requested changes, could you please review it again.

[vaibhavjainwiz]

/retest

[Jooho]

/lgtm

[israel-hdez]

@vaibhavjainwiz Can you, please, squash to a single commit?

[vaibhavjainwiz]

@vaibhavjainwiz Can you, please, squash to a single commit?

done.. I had squash to a single commit.

[heyselbi]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heyselbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• kserve/OWNERS [heyselbi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[LaVLaS]

There are 2 possible fixes for the CI test fallures that are not related to changes in this PR. If those known failures exist in this PR, I will manually merge this to get it unblocked

[heyselbi]

@LaVLaS yep, the e2e ci tests are failing because of codeflare and ray related issues (ie. not related to this PR).

[LaVLaS]

I'm waiting on the outcome of #910 to see if it fixes the CI failures. If Yes, then we should be able to rebase and the CI/CD will be back to normal after a rebase.

If any of those tests in #910 fail, I'll merge this PR manually

[openshift-ci]

@vaibhavjainwiz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/411-odh-manifests-e2e	4b32357	link	true	/test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e	4b32357	link	true	/test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[LaVLaS]

Merging this since it was blocked by the Distributed Workloads test failures that were resolved in #910. The modelmesh test is failing and will be fixed in #918 based on an offline conversation by @VedantMahabaleshwarkar