Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Istio Virtual Host #115

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

israel-hdez
Copy link

Partial revert of
opendatahub-io/odh-manifests#916, because opendatahub-io/odh-model-controller#84 has been completed.

Testing instructions are the same as in #107, but use uri: 'https://github.com/israel-hdez/kserve/tarball/enable-istio-vh in devFlags.

Partial revert of
opendatahub-io/odh-manifests#916, because
opendatahub-io/odh-model-controller#84 has been
completed.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho Jooho removed the lgtm label Oct 26, 2023
@Jooho
Copy link

Jooho commented Oct 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 26, 2023
@heyselbi
Copy link

/lgtm

@openshift-ci openshift-ci bot merged commit 4378291 into opendatahub-io:master Oct 26, 2023
19 checks passed
@israel-hdez israel-hdez deleted the enable-istio-vh branch October 26, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants