Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add a check for DSPO Service Monitor and metrics #831

Merged

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented May 26, 2023

Description

Add an e2e test case for DSPO Service Monitor and metrics. Closes RHODS-8312.

Component repo PR: opendatahub-io/data-science-pipelines-operator#127

How Has This Been Tested?

  • Deploy a DSPA instance
  • Run the following commands:
    • make build -- to create the test container image
    • make run TESTS_REGEX=ml-pipelines
      • This will run the container image locally
      • It will further apply the kfdef defined in the kfctl_openshift.yaml file.
      • If you have the kfdef installed already, you can run this instead:
        make run SKIP_INSTALL=true SKIP_KFDEF_INSTALL=true

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@DharmitD
Copy link
Member Author

/retest

@DharmitD
Copy link
Member Author

@LaVLaS / @VaishnaviHire could you PTAL? Thanks!

@HumairAK
Copy link
Contributor

/lgtm
/approve

@LaVLaS
Copy link
Contributor

LaVLaS commented May 30, 2023

/approve

@DharmitD
Copy link
Member Author

@LaVLaS The e2e checks relevant to this PR have passed, but it appears that the modelmesh e2e tests are failing. Rerunning CI, but would it be possible to merge this PR despite these failing tests?

@DharmitD
Copy link
Member Author

/retest

2 similar comments
@DharmitD
Copy link
Member Author

/retest

@DharmitD
Copy link
Member Author

/retest

@DharmitD DharmitD force-pushed the svc-monitor-test branch from 91701fe to 2e1fe87 Compare May 31, 2023 16:11
@openshift-ci openshift-ci bot removed the lgtm label May 31, 2023
@DharmitD
Copy link
Member Author

/test odh-manifests-e2e

@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 1, 2023

/approve

@DharmitD
Copy link
Member Author

DharmitD commented Jun 1, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2023

@DharmitD: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HumairAK
Copy link
Contributor

HumairAK commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 1, 2023
@LaVLaS
Copy link
Contributor

LaVLaS commented Jun 1, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e688896 into opendatahub-io:master Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants