Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for DSPO Service Monitor and metrics #127

Merged
merged 1 commit into from
May 30, 2023
Merged

Add a check for DSPO Service Monitor and metrics #127

merged 1 commit into from
May 30, 2023

Conversation

DharmitD
Copy link
Member

@DharmitD DharmitD commented May 25, 2023

Description

Add an e2e test case for DSPO Service Monitor and metrics. Closes RHODS-8312.

How Has This Been Tested?

  • Deploy a DSPA instance
  • Run the following commands:
    • make build -- to create the test container image
    • make run TESTS_REGEX=ml-pipelines
      • This will run the container image locally
      • It will further apply the kfdef defined in the kfctl_openshift.yaml file.
      • If you have the kfdef installed already, you can run this instead:
        make run SKIP_INSTALL=true SKIP_KFDEF_INSTALL=true

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@HumairAK
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fdc60b8 into opendatahub-io:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants