Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Integrate TrustyAI notebook into ODH #749

Merged
merged 1 commit into from
May 2, 2023

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Mar 14, 2023

This PR Integrates the TrustyAI notebook into ODH

Description

New files that have been added:

  • notebook-images/base/jupyter-trustyai-notebook-imagestream.yaml
  • tests/resources/notebook-controller/notebooks/jupyter-trustyai-ubi9-python-3-9.yaml

How Has This Been Tested?

Merge criteria:

Should be merged first this PR -> opendatahub-io/notebooks#51

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire March 14, 2023 16:15
@atheo89 atheo89 added this to the ODH 1.5.0 Release milestone Mar 15, 2023
@atheo89
Copy link
Member Author

atheo89 commented Mar 22, 2023

/test odh-manifests-e2e

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 27, 2023

This needs to merge with #740 to ensure that the notebook works with the ODH Core deployment

@atheo89 atheo89 force-pushed the add-trustai branch 2 times, most recently from 2bf3276 to 320a22a Compare March 30, 2023 14:05
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 31, 2023

/retest

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 31, 2023

@RobGeada Can you verify that this notebook works as intended?

@VaishnaviHire
Copy link
Member

@RobGeada any updates on this?

Should this be moved to 1.6 release ?

@openshift-ci
Copy link

openshift-ci bot commented Apr 18, 2023

@atheo89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/49-images 3e3817a link true /test 49-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@atheo89 atheo89 force-pushed the add-trustai branch 2 times, most recently from 1c9f853 to fc03648 Compare May 2, 2023 13:55
@LaVLaS
Copy link
Contributor

LaVLaS commented May 2, 2023

/approve
/lgtm

I could only verify this by running a trustyai example notebook to see if there are any errors.

If there are any issues with the notebook @RobGeada @ruivieira will need to debug and fix

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 559b13a into opendatahub-io:master May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: IDE
Development

Successfully merging this pull request may close these issues.

5 participants