-
Notifications
You must be signed in to change notification settings - Fork 212
Integrate TrustyAI notebook into ODH #749
Integrate TrustyAI notebook into ODH #749
Conversation
/test odh-manifests-e2e |
This needs to merge with #740 to ensure that the notebook works with the ODH Core deployment |
2bf3276
to
320a22a
Compare
/retest |
@RobGeada Can you verify that this notebook works as intended? |
@RobGeada any updates on this? Should this be moved to 1.6 release ? |
@atheo89: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1c9f853
to
fc03648
Compare
/approve I could only verify this by running a trustyai example notebook to see if there are any errors. If there are any issues with the notebook @RobGeada @ruivieira will need to debug and fix |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR Integrates the TrustyAI notebook into ODH
Description
New files that have been added:
notebook-images/base/jupyter-trustyai-notebook-imagestream.yaml
tests/resources/notebook-controller/notebooks/jupyter-trustyai-ubi9-python-3-9.yaml
How Has This Been Tested?
Merge criteria:
Should be merged first this PR -> opendatahub-io/notebooks#51