Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

FAI-957: TrustyAI inclusion #740

Merged
merged 11 commits into from
Mar 30, 2023

Conversation

RobGeada
Copy link
Contributor

@RobGeada RobGeada commented Mar 1, 2023

Description

  • Added TrustyAI manifests to trustyai directory
  • Added TrustyAI overlay to modelmesh, to select specific trustyai modelmesh repo

How Has This Been Tested?

The E2E test in the TrustyAI downstream repo

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Testing instructions:

  1. Install the ODH operator into your cluster
  2. git clone https://github.com/red-hat-data-services/trustyai-explainability
  3. Run the E2E test from the the TrustyAI downstream repo: ./odh-deployment-e2e.sh robgeada FAI-957-trustyai

@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

Hi @RobGeada. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RobGeada RobGeada force-pushed the FAI-957-trustyai branch 2 times, most recently from 407c118 to c13f963 Compare March 7, 2023 17:29
@RobGeada RobGeada marked this pull request as ready for review March 7, 2023 17:31
@openshift-ci openshift-ci bot requested review from anishasthana and LaVLaS March 7, 2023 17:32
@RobGeada RobGeada force-pushed the FAI-957-trustyai branch 2 times, most recently from e7d2d7f to ea10019 Compare March 15, 2023 17:45
@RobGeada
Copy link
Contributor Author

/retest

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 21, 2023

@RobGeada @anishasthana Do you have a set up CI tests to add so we can verify Trusty AI is working

@RobGeada
Copy link
Contributor Author

@RobGeada @anishasthana Do you have a set up CI tests to add so we can verify Trusty AI is working

@LaVLaS Working on those now

@RobGeada
Copy link
Contributor Author

@RobGeada @anishasthana Do you have a set up CI tests to add so we can verify Trusty AI is working

@LaVLaS CI tests are now included

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 24, 2023

/ok-to-test

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 24, 2023

/retest

CI infra issues

Copy link
Contributor

@LaVLaS LaVLaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally delete the Makefle we use to build and run CI tests

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 25, 2023

/retest

@RobGeada
Copy link
Contributor Author

I think you accidentally delete the Makefle we use to build and run CI tests

Yep, that is now restored

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 27, 2023

/retest

LaVLaS
LaVLaS previously approved these changes Mar 27, 2023
@openshift-ci openshift-ci bot added the lgtm label Mar 27, 2023
@RobGeada
Copy link
Contributor Author

Update: The CI failures are being caused by the v0.11.0 build of the modelmesh-runtime-adapter, issue is opened here: kserve/modelmesh-runtime-adapter#41

@LaVLaS LaVLaS force-pushed the FAI-957-trustyai branch from fb34683 to 039fdf4 Compare March 29, 2023 19:24
@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 30, 2023

@RobGeada Can you add an OWNERS file to the root of the trustyai-service directory so that users know who to tag for any issues

@RobGeada
Copy link
Contributor Author

@RobGeada Can you add an OWNERS file to the root of the trustyai-service directory so that users know who to tag for any issues

Done

@RobGeada
Copy link
Contributor Author

/ok-to-test

@LaVLaS
Copy link
Contributor

LaVLaS commented Mar 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 30, 2023
Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobGeada Thanks for your efforts on this!

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, ruivieira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants