Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change models tooltip to popover #3344

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Oct 17, 2024

Closes: RHOAIENG-10992

Description

Updates the data science projects models page to use a popover instead of a tooltip for the status. The message will no longer disappear when trying to select the text, and removes the issue of the screen shaking if the message is too long.

How Has This Been Tested?

Tested locally

Test Impact

Adjusted cypress tests to check for popover instead of tooltip

Screenshots

Before (hover for tooltip):
Screenshot 2024-10-16 at 3 47 40 PM

After (click for popover)"
Screenshot 2024-10-16 at 3 47 13 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti October 17, 2024 13:12
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manaswinidas manaswinidas mentioned this pull request Oct 17, 2024
6 tasks
@jenny-s51 jenny-s51 self-requested a review October 17, 2024 14:36
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.07%. Comparing base (3f41512) to head (af8cfab).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...lServing/screens/global/InferenceServiceStatus.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3344      +/-   ##
==========================================
+ Coverage   84.79%   85.07%   +0.28%     
==========================================
  Files        1315     1327      +12     
  Lines       29494    29771     +277     
  Branches     8059     8150      +91     
==========================================
+ Hits        25008    25328     +320     
+ Misses       4486     4443      -43     
Files with missing lines Coverage Δ
...lServing/screens/global/InferenceServiceStatus.tsx 79.31% <75.00%> (+0.73%) ⬆️

... and 99 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f41512...af8cfab. Read the comment docs.

@ashley-o0o ashley-o0o force-pushed the 10993/model-popover branch 3 times, most recently from da63676 to 987c0c9 Compare October 17, 2024 19:31
Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Models popover is looking awesome for error states @ashley-o0o! Left a comment below about the progress states .

@ashley-o0o ashley-o0o force-pushed the 10993/model-popover branch 2 times, most recently from d56bdb6 to f4404b4 Compare October 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants