-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change models tooltip to popover #3344
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3344 +/- ##
==========================================
+ Coverage 84.79% 85.07% +0.28%
==========================================
Files 1315 1327 +12
Lines 29494 29771 +277
Branches 8059 8150 +91
==========================================
+ Hits 25008 25328 +320
+ Misses 4486 4443 -43
... and 99 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Show resolved
Hide resolved
da63676
to
987c0c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Models popover is looking awesome for error states @ashley-o0o! Left a comment below about the progress states .
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Outdated
Show resolved
Hide resolved
987c0c9
to
6197203
Compare
frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
Outdated
Show resolved
Hide resolved
d56bdb6
to
f4404b4
Compare
f4404b4
to
549ceb5
Compare
17543a3
to
af8cfab
Compare
Closes: RHOAIENG-10992
Description
Updates the data science projects models page to use a popover instead of a tooltip for the status. The message will no longer disappear when trying to select the text, and removes the issue of the screen shaking if the message is too long.
How Has This Been Tested?
Tested locally
Test Impact
Adjusted cypress tests to check for popover instead of tooltip
Screenshots
Before (hover for tooltip):
After (click for popover)"
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main