Fixed a11y failures

opendatahub-io · Oct 18, 2024 · 17543a3 · 17543a3
1 parent 549ceb5
commit 17543a3
Showing 1 changed file with 5 additions and 37 deletions.
diff --git a/frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx b/frontend/src/pages/modelServing/screens/global/InferenceServiceStatus.tsx
@@ -37,29 +37,13 @@ const InferenceServiceStatus: React.FC<InferenceServiceStatusProps> = ({
       case InferenceServiceModelState.LOADED:
       case InferenceServiceModelState.STANDBY:
         return (
-          <Icon
-            data-testid="status-tooltip"
-            role="button"
-            aria-label="success icon"
-            status="success"
-            isInline
-            tabIndex={0}
-            iconSize={iconSize}
-          >
+          <Icon data-testid="status-tooltip" status="success" isInline iconSize={iconSize}>
             <CheckCircleIcon />
           </Icon>
         );
       case InferenceServiceModelState.FAILED_TO_LOAD:
         return (
-          <Icon
-            data-testid="status-tooltip"
-            role="button"
-            aria-label="error icon"
-            status="danger"
-            isInline
-            tabIndex={0}
-            iconSize={iconSize}
-          >
+          <Icon data-testid="status-tooltip" status="danger" isInline iconSize={iconSize}>
             <ExclamationCircleIcon />
           </Icon>
         );
@@ -72,29 +56,13 @@ const InferenceServiceStatus: React.FC<InferenceServiceStatusProps> = ({
         );
       case InferenceServiceModelState.UNKNOWN:
         return (
-          <Icon
-            data-testid="status-tooltip"
-            role="button"
-            aria-label="warning icon"
-            status="warning"
-            isInline
-            tabIndex={0}
-            iconSize={iconSize}
-          >
+          <Icon data-testid="status-tooltip" status="warning" isInline iconSize={iconSize}>
             <OutlinedQuestionCircleIcon />
           </Icon>
         );
       default:
         return (
-          <Icon
-            data-testid="status-tooltip"
-            role="button"
-            aria-label="warning icon"
-            status="warning"
-            isInline
-            tabIndex={0}
-            iconSize={iconSize}
-          >
+          <Icon data-testid="status-tooltip" status="warning" isInline iconSize={iconSize}>
             <OutlinedQuestionCircleIcon />
           </Icon>
         );
@@ -112,7 +80,7 @@ const InferenceServiceStatus: React.FC<InferenceServiceStatusProps> = ({
       bodyContent={bodyContent}
       isVisible={bodyContent ? undefined : false}
     >
-      <Button variant="link" isInline icon={statusIcon()} />
+      <Button aria-label="status" variant="link" isInline icon={statusIcon()} />
     </Popover>
   );
 };