NO-JIRA: chore(tests) Update readme for tests execution + some test fixes for linux env #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
reviewed
Jan 24, 2025
jiridanek
reviewed
Jan 24, 2025
jiridanek
reviewed
Jan 24, 2025
jstourac
changed the title
|
/override ci/prow/images |
|
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added some more steps to configure the environment to make tests work on local machine.
There is necessary to use "z" option when mounting files into the container otherwise SELinux will not allow container to read the mounted file. Also, I've adjusted the UIDs used in the tests so that they are lower than 65k because otherwise it's not possible to run these with a root-less podman/docker.
|
/override ci/prow/images |
|
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Everything looks good on my end, adding logs in case of comparison. /lgtm |
|
/lgtm |
|
This may go in later, or maybe never, but these two commands may be useful for macOS If you messed with SELinux in your env before Check that the podman cli is fine with the socket you are using, it's better for diagnosing problems than just running testcontainers. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll keep this up to you as a MacOS user. I'm gonna merge this one now. 🙂 Thank you all for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes for the tests execution readme and some fixes for tests execution on a Linux machine.
This is waiting once
TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE#861is merged first.
Description
@jiridanek says: The "random" uid changes are because rootless podman can only handle UIDs from$0$ to $2^{16} - 1$ inside the container. There's a trick in podman that maps the in-container UIDs to host system's UIDs, and there is only so much UIDs that can be mapped.
How Has This Been Tested?
Merge criteria: