Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: chore(tests/containers): improve docker socket detection, reducing the need for TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE #861

Conversation

jiridanek
Copy link
Member

Description

Volunteers with Linux machines are hereby encouraged to put it to the test. This is to simplify the README.md instructions that Jan is writing down.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…ducing the need for `TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE`
@jstourac
Copy link
Member

I can confirm that this works on my machine - no need to specify the TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE variable anymore.

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit adbd066 into opendatahub-io:main Jan 24, 2025
14 checks passed
@jiridanek jiridanek deleted the jd_reduce_need_for_TESTCONTAINERS_DOCKER_SOCKET_OVERRIDE branch January 24, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants