[RHOAIENG-10904] Updated istio versions based on go version 1.21 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholder6
force-pushed
the
updateistio-cp
branch
5 times, most recently
from
fbec717 to
c5faaba
Compare
Signed-off-by: mholder6 <marholde@redhat.com>
mholder6
force-pushed
the
updateistio-cp
branch
from
c5faaba to
ef3369f
Compare
mholder6
changed the title
Comment on lines
+31
to
+32
| k8s.io/api v0.29.0 | ||
| k8s.io/apimachinery v0.29.0 |
There was a problem hiding this comment.
These are also bumped. Was there a reason?
There was a problem hiding this comment.
I believe these were the same case -- automatically upgrading after running go mod tidy; after upgrading the istio libs
There was a problem hiding this comment.
left a comment in the upstream PR.
spolti
changed the title
spolti
approved these changes
Aug 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mholder6, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 9a6524e
into
opendatahub-io:master
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking kserve#3825
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.